Skip to content

fix(core): use next available port when the port for nx graph is in use #31365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented May 28, 2025

Current Behavior

Command would fail silently with no error message

Expected Behavior

Rather than erroring, Nx will find the next available port and use that.

Related Issue(s)

Fixes #30915

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner May 28, 2025 01:27
@FrozenPandaz FrozenPandaz requested a review from Cammisuli May 28, 2025 01:27
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 28, 2025 9:50pm

Copy link
Contributor

nx-cloud bot commented May 28, 2025

View your CI Pipeline Execution ↗ for commit 0e74b14.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 2m 48s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 6s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-28 21:55:02 UTC

@FrozenPandaz FrozenPandaz force-pushed the fix-nx-graph-port-conflict branch 3 times, most recently from 61b59ef to c912529 Compare May 28, 2025 19:57
@FrozenPandaz FrozenPandaz force-pushed the fix-nx-graph-port-conflict branch from c912529 to 827dc85 Compare May 28, 2025 21:34
@FrozenPandaz FrozenPandaz force-pushed the fix-nx-graph-port-conflict branch from 827dc85 to 0e74b14 Compare May 28, 2025 21:47
@FrozenPandaz FrozenPandaz changed the title fix(core): throw an error when the port for nx graph is in use fix(core): use next available port when the port for nx graph is in use May 28, 2025
@FrozenPandaz FrozenPandaz merged commit 2f37cb2 into master May 29, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-nx-graph-port-conflict branch May 29, 2025 13:47
FrozenPandaz added a commit that referenced this pull request Jun 3, 2025
…se (#31365)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Command would fail silently with no error message
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Rather than erroring, Nx will find the next available port and use that.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #30915

(cherry picked from commit 2f37cb2)
Copy link

github-actions bot commented Jun 4, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx graph fails silently if port already taken
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy