feat(repo): Add golden list of projects to our Nightly CI #31414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 45021c5.
☁️ Nx Cloud last updated this comment at |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
72eb9a9 to
6828325
Compare
6828325 to
5dde801
Compare
5dde801 to
a0f7e5e
Compare
a0f7e5e to
3c628da
Compare
3c628da to
f9027c0
Compare
f9027c0 to
11f8619
Compare
11f8619 to
c6bc00d
Compare
c6bc00d to
43dc38e
Compare
43dc38e to
917b7e9
Compare
1e00cff to
65b9647
Compare
65b9647 to
12bde36
Compare
5829801 to
a994c9f
Compare
fe92ff8 to
87dda95
Compare
jaysoo
reviewed
Jun 4, 2025
jaysoo
reviewed
Jun 4, 2025
jaysoo
reviewed
Jun 4, 2025
jaysoo
reviewed
Jun 4, 2025
87dda95 to
45021c5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR marks core projects as “golden” in the Nightly CI matrix, replaces the inline GitHub Script with a TypeScript script to process results (highlighting golden failures), and enhances caching and macOS simulator handling in the end-to-end workflow.
- Mark core e2e projects as golden and propagate
is_goldenthrough matrix - Add
process-result.tsto generate detailed Slack reports and duration tables - Improve pnpm caching and macOS simulator setup/reset in
e2e-matrix.yml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/nightly/process-matrix.ts | Added is_golden flag to project definitions and matrix items |
| .github/workflows/nightly/process-result.ts | New TypeScript script to process test results and format Slack output |
| .github/workflows/e2e-matrix.yml | Enhanced caching, robust macOS simulator reset, wired in TS script |
Comments suppressed due to low confidence (2)
.github/workflows/nightly/process-result.ts:32
- Consider adding unit tests for
processResultsto verify formatting and logic for both golden and regular project failure scenarios.
function processResults(combined: MatrixResult[]): ProcessedResults {
.github/workflows/nightly/process-result.ts:21
- Add a JSDoc comment explaining that
humanizeDurationexpects its input in seconds and returns a human-readable duration string.
function humanizeDuration(num: number): string {
FrozenPandaz
approved these changes
Jun 5, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 5, 2025
This pull request introduces several updates to the CI/CD workflows and matrix configuration files. The aim is to highlight critical Nx failures contained in each project for maintainers to address. ### Changes - Improvements to workflow caching. - Improvements to macOS simulator handling. - Updates to Slack notifications. - Update matrix data processing for golden projects. - Support for Windows has been temporarily disabled due to build issues. (cherry picked from commit 6fe9d29)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the CI/CD workflows and matrix configuration files.
The aim is to highlight critical Nx failures contained in each project for maintainers to address.
Changes