fix(rspack): ensure nest applications generated correctly #31204 #31424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 5ada05e.
☁️ Nx Cloud last updated this comment at |
c66a6b8 to
541cc8f
Compare
541cc8f to
9a8a5d3
Compare
jaysoo
reviewed
Jun 3, 2025
jaysoo
approved these changes
Jun 3, 2025
Co-authored-by: Coly010 <Coly010@users.noreply.github.com>
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 3, 2025
) - fix(rspack): choosing nest as framework should not result in error #31204 - fix(rspack): add deprecation message for application generator - fix(rspack): ensure application generated projects are added to excludes ## Current Behavior Running the `@nx/rspack:application` generator with `--framework=nest` results in an error due to mix of inferred and executor usage throughout the generation process. ## Expected Behavior Running the generator should pass without failure and create a working project. Deprecate the generator in favour of using project specific packages (@nx/react etc) ## Related Issue(s) Fixes #31204 --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Coly010 <Coly010@users.noreply.github.com> (cherry picked from commit 34cf5a2)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running the
@nx/rspack:applicationgenerator with--framework=nestresults in an error due to mix of inferred and executor usage throughout the generation process.Expected Behavior
Running the generator should pass without failure and create a working project.
Deprecate the generator in favour of using project specific packages (@nx/react etc)
Related Issue(s)
Fixes #31204