fix(vite): NxReporter compatible with Vitest ≥0.29 #31425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Hardanish-Singh
approved these changes
Jun 2, 2025
Coly010
approved these changes
Jun 9, 2025
|
View your CI Pipeline Execution ↗ for commit 5a03956.
☁️ Nx Cloud last updated this comment at |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx test … --reporter=verbose(or any additional Vitest reporter) onprojects that use Vitest ≥ 0.29 hangs indefinitely at the end of the run.
vitestitself finishes, but the Nx task-runner never receives the donesignal because
NxReporteronly implements the legacyonFinished()hook.When multiple reporters are configured, Vitest now emits
onTestRunEnd()instead ofonFinished(), so the promise inNxReporterremains unresolved and the worker process stays alive forever.
Expected Behavior
nx test(and affectednx run-many --target=test) exits cleanly on allVitest versions, regardless of how many reporters are passed.
NxReporterresolves its internal promise via eitheronTestRunEnd(Vitest ≥ 0.29) oronFinished(Vitest ≤ 0.28).Implementation Notes
onTestRunEndmethod that delegates to a private_handleFinished.onFinishedas a thin delegate to the same helper.Related Issue(s)
Closes nrwl/nx#<insert-issue-number-if/when-one-exists>