fix(core): use ts-node option from tsconfig files when creating transpiler
#31469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 58cdfeb.
☁️ Nx Cloud last updated this comment at |
f581c6a to
58cdfeb
Compare
FrozenPandaz
approved these changes
Jun 5, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 5, 2025
…nspiler (#31469) ## Current Behavior When creating a `ts-node` transpiler, only `compilerOptions` are provided. Because we instruct `ts-node` to skip reading the tsconfig (this was previously done to avoid some edge cases), other options in the tsconfig files are lost (e.g. `ts-node` specific options). This was previously reported at #21695 and fixed by #21723, but a rework at a later point caused a regression. ## Expected Behavior When creating a `ts-node` transpiler, we should provide `compilerOptions` and the `ts-node` options. (cherry picked from commit 9323403)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When creating a
ts-nodetranspiler, onlycompilerOptionsare provided. Because we instructts-nodeto skip reading the tsconfig (this was previously done to avoid some edge cases), other options in the tsconfig files are lost (e.g.ts-nodespecific options).This was previously reported at #21695 and fixed by #21723, but a rework at a later point caused a regression.
Expected Behavior
When creating a
ts-nodetranspiler, we should providecompilerOptionsand thets-nodeoptions.