fix(nuxt): respect `baseURL` when ignoring prerendered manifest #30446

TheAlexLichter · 2025-01-03T19:09:10Z

🔗 Linked issue

Resolves #30367

📚 Description

Adds the baseURL to the manifest preload path.

bolt-new-by-stackblitz · 2025-01-03T19:09:12Z

Run & review this pull request in StackBlitz Codeflow.

packages/nuxt/src/core/nitro.ts

coderabbitai · 2025-01-03T19:13:47Z

Warning

Rate limit exceeded

@danielroe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 18 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 786d0cf and a524a63.

📒 Files selected for processing (1)

packages/nuxt/src/core/nitro.ts (1 hunks)

Walkthrough

The pull request introduces modifications to the Nuxt core Nitro initialisation process within the packages/nuxt/src/core/nitro.ts file. A new baseURL variable is introduced, which determines the base path for asset management by leveraging runtime and application configuration options. The implementation adjusts how the manifest prefix is constructed and includes a new configuration for public assets related to build manifests.

Additionally, the error handling logic is updated to conditionally set the error handler based on development mode and experimental server configurations. These changes enhance the configuration and handling of assets and errors within the Nitro initialisation process.

The changes do not alter the function signature but modify the internal implementation of the initNitro function, potentially impacting how Nuxt applications manage assets and handle runtime errors.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61ddea1 and ecad51a.

📒 Files selected for processing (1)

packages/nuxt/src/core/nitro.ts (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

packages/nuxt/src/core/nitro.ts

[error] 252-252: The assignment should not be in an expression.

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

(lint/suspicious/noAssignInExpressions)

packages/nuxt/src/core/nitro.ts

TheAlexLichter · 2025-01-03T21:34:44Z

As a note: This fixes local generate but I wonder if this will conflict with static deployments to e.g. cloudflare or vercel, as we extend the URL with the baseURL manually there.
(Stumbled upon while checking nitrojs/nitro#1484)

Example of the problem with /test/ base url and this fix.

As a solution, we could add the baseUrl to all static presets to have a uniform way of dealing with static generation in nitro, but this might be a breaking change.

danielroe · 2025-01-04T21:14:37Z

~~having taken a look, I suspect the issue here is not the path of the build assets file at this point but what we're rendering here~~

no, it correctly renders it - the issue is the prerender ignore pattern

…-url

…#30446)

fix: consider baseURL for preloading manifest

ecad51a

github-actions bot added 3.x bug labels Jan 3, 2025

TheAlexLichter commented Jan 3, 2025

View reviewed changes

packages/nuxt/src/core/nitro.ts Outdated Show resolved Hide resolved

TheAlexLichter marked this pull request as ready for review January 3, 2025 19:10

TheAlexLichter requested a review from danielroe as a code owner January 3, 2025 19:10

TheAlexLichter changed the title ~~fix: consider baseURL for preloading manifest~~ fix: respect baseURL for preloading manifest Jan 3, 2025

coderabbitai bot reviewed Jan 3, 2025

View reviewed changes

packages/nuxt/src/core/nitro.ts Outdated Show resolved Hide resolved

TheAlexLichter added 2 commits January 3, 2025 20:19

chore: remove reassign

786d0cf

Update nitro.ts

53ccbb6

TheAlexLichter mentioned this pull request Jan 3, 2025

fix(netlify): support custom baseURL nitrojs/nitro#2966

Merged

8 tasks

danielroe added 2 commits January 4, 2025 22:06

Merge remote-tracking branch 'origin/main' into fix/app-manifest-base…

d60e1e6

…-url

fix: update ignore path

a524a63

danielroe changed the title ~~fix: respect baseURL for preloading manifest~~ fix(nuxt): respect baseURL when ignoring prerendered manifest Jan 4, 2025

danielroe merged commit 7d96a0f into main Jan 4, 2025
45 checks passed

danielroe deleted the fix/app-manifest-base-url branch January 4, 2025 22:35

github-actions bot mentioned this pull request Jan 4, 2025

v4.0.0 #27716

Merged

danielroe pushed a commit that referenced this pull request Jan 4, 2025

fix(nuxt): respect baseURL when ignoring prerendered manifest (#30446)

6a6bae7

github-actions bot mentioned this pull request Jan 4, 2025

v3.15.1 #30373

Merged

Kamsou pushed a commit to Kamsou/nuxt that referenced this pull request Feb 5, 2025

fix(nuxt): respect baseURL when ignoring prerendered manifest (nuxt…

8839dea

…#30446)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): respect `baseURL` when ignoring prerendered manifest #30446

fix(nuxt): respect `baseURL` when ignoring prerendered manifest #30446

Uh oh!

TheAlexLichter commented Jan 3, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Jan 3, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

TheAlexLichter commented Jan 3, 2025 •

edited

Loading

Uh oh!

danielroe commented Jan 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

fix(nuxt): respect baseURL when ignoring prerendered manifest #30446

fix(nuxt): respect baseURL when ignoring prerendered manifest #30446

Uh oh!

Conversation

TheAlexLichter commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jan 3, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheAlexLichter commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielroe commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix(nuxt): respect `baseURL` when ignoring prerendered manifest #30446

fix(nuxt): respect `baseURL` when ignoring prerendered manifest #30446

TheAlexLichter commented Jan 3, 2025 •

edited

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

TheAlexLichter commented Jan 3, 2025 •

edited

Loading

danielroe commented Jan 4, 2025 •

edited

Loading