perf(nuxt): use lighter @nuxt/cli dependency
#30526
Conversation
|
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
WalkthroughThe pull request includes updates across multiple files related to the Nuxt CLI module. In Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@nuxt/cli dep internally@nuxt/cli dependency
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/nuxt/src/core/features.ts (1)
Line range hint
44-44: Update or remove the outdated TODO commentThe TODO comment "refactor to Nuxi" appears to be outdated now that we're moving away from 'nuxi' to '@nuxt/cli'.
Consider removing or updating the comment to reflect the current architecture:
-// TODO: refactor to Nuxi +// TODO: refactor to @nuxt/cli
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/nuxt/build.config.ts(1 hunks)packages/nuxt/src/core/features.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: code
🔇 Additional comments (2)
packages/nuxt/build.config.ts (1)
25-25: Verify compatibility with existing Nuxt applicationsThe change from 'nuxi' to '@nuxt/cli' appears to align with the performance improvement objective. However, we should ensure this doesn't introduce breaking changes for existing applications.
Let's verify the dependency change impact:
✅ Verification successful
Internal implementation change maintains backward compatibility
The change from 'nuxi' to '@nuxt/cli' is an internal implementation detail that maintains backward compatibility through bin aliases in the package.json. Existing applications using the 'nuxi' command will continue to work as before.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any direct imports of 'nuxi' in the codebase rg --type ts --type js "from ['|\"]nuxi['\"]" # Check package.json for version constraints fd "package.json" --type f --exec cat {} \; | jq -r 'select(.dependencies != null) | select(.dependencies["nuxi"] != null) | .dependencies["nuxi"]'Length of output: 202
Script:
#!/bin/bash # Search for any occurrence of 'nuxi' or '@nuxt/cli' echo "=== Searching for nuxi and @nuxt/cli references ===" rg -i "nuxi|@nuxt/cli" -g '!{node_modules,dist}/*' # Check package.json contents echo -e "\n=== Examining package.json files ===" fd "package.json" --type f --exec cat {} # Look for migration guides echo -e "\n=== Checking for migration documentation ===" fd -g "*MIGRATION*.md" -g "*CHANGELOG*.md" -g "README.md" --type f --exec cat {}Length of output: 44334
packages/nuxt/src/core/features.ts (1)
56-56: LGTM! Import change aligns with dependency updateThe change to import
runCommandfrom '@nuxt/cli' is consistent with the dependency update in build.config.ts.
🔗 Linked issue
📚 Description
rationale: nuxt/cli#648