Skip to content

ci: reenable nuxt benchmarking #30711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2025
Merged

ci: reenable nuxt benchmarking #30711

merged 3 commits into from
Jan 22, 2025

Conversation

danielroe
Copy link
Member

🔗 Linked issue

📚 Description

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@socket-security Socket Security
Copy link

socket-security bot commented Jan 22, 2025 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@codspeed/vitest-plugin@4.0.0 Transitive: environment, eval, filesystem, network +8 4.16 MB art049

View full report↗︎

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 22, 2025 •
edited
Loading

Open in Stackblitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@30711

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@30711

nuxt

npm i https://pkg.pr.new/nuxt@30711

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@30711

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@30711

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@30711

commit: 7ea7240

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #30711 will create unknown performance changes

Comparing ci/benchmark (7ea7240) with main (1a9fb57)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

🆕 8 new benchmarks
⁉️ 8 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ basic test fixture 86.7 ms N/A N/A
⁉️ basic test fixture (types) 67.6 ms N/A N/A
⁉️ empty directory 22.2 ms N/A N/A
🆕 loadNuxtConfig in the basic test fixture N/A 190 ms N/A
🆕 loadNuxtConfig in the basic test fixture (types) N/A 16.7 ms N/A
🆕 loadNuxtConfig in the empty directory N/A 84.9 ms N/A
🆕 loadNuxtConfig in the minimal test fixture N/A 13.3 ms N/A
🆕 loadNuxtConfig in the minimal test fixture (types) N/A 11.9 ms N/A
⁉️ minimal test fixture 8.3 ms N/A N/A
⁉️ minimal test fixture (types) 31.2 ms N/A N/A
⁉️ write types 163.1 ms N/A N/A
🆕 writeTypes in the basic-types fixture N/A 256.8 ms N/A
⁉️ basic test fixture 2.1 s N/A N/A
⁉️ empty directory 432.9 ms N/A N/A
🆕 loadNuxt in an empty directory N/A 1.5 s N/A
🆕 loadNuxt in the basic test fixture N/A 2.4 s N/A

@danielroe danielroe marked this pull request as ready for review January 22, 2025 17:28
@danielroe danielroe merged commit 8256f4b into main Jan 22, 2025
49 of 50 checks passed
@danielroe danielroe deleted the ci/benchmark branch January 22, 2025 17:28
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2025

Caution

Review failed

The pull request is closed.

Pull Request Analysis

Walkthrough

This pull request introduces changes to the project's benchmarking infrastructure. The primary modifications include removing the standalone benchmark workflow and integrating benchmarking directly into the continuous integration (CI) workflow. The benchmark-related configuration has been updated across multiple files, including workflow definitions, test configurations, and benchmark test files.

The changes involve updating import paths for various functions from relative to absolute package imports, modifying benchmark test descriptions for improved clarity, and adding the CodSpeedHQ benchmarking plugin to the Vitest configuration. A new test-benchmark job has been added to the CI workflow, which runs benchmarks using the CodSpeedHQ action and executes benchmark tests across different packages.

These modifications aim to streamline the benchmarking process and improve the overall testing infrastructure of the project.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f76a48 and 7ea7240.

⛔ Files ignored due to path filters (2)
  • package.json is excluded by !package.json, !**/package.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (6)
  • .github/workflows/benchmark.yml (0 hunks)
  • .github/workflows/ci.yml (1 hunks)
  • packages/kit/test/load-nuxt-config.bench.ts (2 hunks)
  • packages/kit/test/write-types.bench.ts (2 hunks)
  • packages/nuxt/test/load-nuxt.bench.ts (1 hunks)
  • vitest.config.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

danielroe added a commit that referenced this pull request Jan 22, 2025
@danielroe
ci: reenable nuxt benchmarking (#30711)
a49329b
This was referenced Jan 22, 2025
Merged
Merged
Kamsou pushed a commit to Kamsou/nuxt that referenced this pull request Feb 5, 2025
@danielroe @Kamsou
ci: reenable nuxt benchmarking (nuxt#30711)
ee1dfdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy