Skip to content

fix(nuxt): support template string quotes in resolveComponent #31526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix(nuxt): support template string quotes in resolveComponent #31526

merged 1 commit into from
Mar 26, 2025

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #31503

📚 Description

This refactors the component loader regexp for greater soundness, using named groups and supporting template string literals.

@danielroe danielroe added the 3.x label Mar 25, 2025
@danielroe danielroe requested a review from huang-julien March 25, 2025 10:00
@danielroe danielroe self-assigned this Mar 25, 2025
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the bug label Mar 25, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2025

Walkthrough

The changes modify a regular expression and the corresponding callback function used in a string replacement. The regular expression has been updated to include named capturing groups for the quote character, lazy prefixes, modifiers, and component names, making the captured segments explicit. Concurrently, the callback function’s signature has been altered: it now utilises a rest parameter (...args), with the required values extracted from the arguments array instead of being passed as fixed individual parameters. These revisions affect the parsing and handling of the string to extract component-related details.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f10df4 and 21299a5.

📒 Files selected for processing (1)
  • packages/nuxt/src/components/plugins/loader.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: code
🔇 Additional comments (2)
packages/nuxt/src/components/plugins/loader.ts (2)

24-24: Excellent enhancement to the regex pattern with named groups

The updated regex now includes named capturing groups (?<quote>, ?<lazy>, ?<modifier>, ?<name>), making the pattern more maintainable and easier to understand. The addition of backtick support (["']) allows template string literals to be properly matched, and using the backreference \k` ensures the closing quote matches the opening one. This is a robust solution that improves both functionality and readability.

50-51: Well-structured adaptation to work with named capture groups

The callback signature change from explicitly defined parameters to using a rest parameter with destructuring is the proper approach for working with named capturing groups. Extracting the properties from the last element of args aligns with how named capture groups are provided by the JavaScript regex engine. This change maintains full compatibility with the existing logic while supporting the enhanced regex capabilities.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 25, 2025

Open in Stackblitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@31526

nuxt

npm i https://pkg.pr.new/nuxt@31526

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@31526

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@31526

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@31526

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@31526

commit: 21299a5

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Performance Report

Merging #31526 will not alter performance

Comparing fix/template-quote (21299a5) with main (5f10df4)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit 23b10f4 into main Mar 26, 2025
45 checks passed
@danielroe danielroe deleted the fix/template-quote branch March 26, 2025 10:24
@github-actions github-actions bot mentioned this pull request Mar 26, 2025
Merged
danielroe added a commit that referenced this pull request Mar 26, 2025
@danielroe
fix(nuxt): support template string quotes in resolveComponent (#31526)
eb41758
@github-actions github-actions bot mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huang-julien huang-julien Awaiting requested review from huang-julien

Assignees

@danielroe danielroe

Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resolveComponent() doesn't accept template string
1 participant
@danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy