fix(kit): include user-defined types before internal ones when generating `tsconfig.json` #31882

DamianGlowala · 2025-04-23T17:33:28Z

🔗 Linked issue

resolves #20379

📚 Description

This prioritises user-defined types over nuxt.d.ts (and others) and removes redundant .config/nuxt.* entry which is already included in **/*.

…en generating `tsconfig.json`

bolt-new-by-stackblitz · 2025-04-23T17:33:32Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-04-23T17:35:39Z

Walkthrough

The changes reorder the initialization sequence of the include set within the _generateTypes function in the template.ts file, placing the pattern matching all files (**/*) first, followed by the .config/nuxt.* pattern, and finally './nuxt.d.ts'. A new TypeScript declaration file is added in the test fixtures, which augments the nuxt/schema module by introducing a PublicRuntimeConfig interface containing an ids property limited to an array of the numeric literals 1, 2, or 3. Corresponding test type assertions are updated to reflect this more specific type, changing the expected type of runtimeConfig.public.ids from a generic number[] to (1 | 2 | 3)[] in multiple test locations. No other logic or exported public entity declarations are modified.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65199e7 and a96f23f.

📒 Files selected for processing (1)

packages/kit/src/template.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/kit/src/template.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: code
GitHub Check: codeql (javascript-typescript)
GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-04-23T17:42:27Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@31882

nuxt

npm i https://pkg.pr.new/nuxt@31882

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@31882

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@31882

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@31882

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@31882

commit: a96f23f

codspeed-hq · 2025-04-23T17:47:34Z

CodSpeed Performance Report

Merging #31882 will not alter performance

_{Comparing fix/typing-runtime-config (a96f23f) with main (4a77184)}

Summary

✅ 10 untouched benchmarks

packages/kit/src/template.ts

…g.json` (#31882)

DamianGlowala added 2 commits April 23, 2025 18:54

fix(kit): add user-provided type declarations before internal ones wh…

fb24478

…en generating `tsconfig.json`

chore: adjust tests

65199e7

DamianGlowala self-assigned this Apr 23, 2025

DamianGlowala requested a review from danielroe as a code owner April 23, 2025 17:33

github-actions bot added 3.x bug labels Apr 23, 2025

danielroe reviewed Apr 23, 2025

View reviewed changes

packages/kit/src/template.ts Show resolved Hide resolved

fix: bring back .config/nuxt.* glob

a96f23f

danielroe approved these changes Apr 24, 2025

View reviewed changes

danielroe merged commit 712cd6c into main Apr 24, 2025
84 of 86 checks passed

danielroe deleted the fix/typing-runtime-config branch April 24, 2025 13:06

github-actions bot mentioned this pull request Apr 24, 2025

v4.0.0 #27716

Merged

danielroe pushed a commit that referenced this pull request Apr 24, 2025

fix(kit): include user-defined types before internal ones in `tsconfi…

5693f9d

…g.json` (#31882)

github-actions bot mentioned this pull request Apr 24, 2025

v3.17.0 #31687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(kit): include user-defined types before internal ones when generating `tsconfig.json` #31882

fix(kit): include user-defined types before internal ones when generating `tsconfig.json` #31882

Uh oh!

DamianGlowala commented Apr 23, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Apr 23, 2025

Uh oh!

coderabbitai bot commented Apr 23, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

fix(kit): include user-defined types before internal ones when generating tsconfig.json #31882

fix(kit): include user-defined types before internal ones when generating tsconfig.json #31882

Uh oh!

Conversation

DamianGlowala commented Apr 23, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Apr 23, 2025

Uh oh!

coderabbitai bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #31882 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix(kit): include user-defined types before internal ones when generating `tsconfig.json` #31882

fix(kit): include user-defined types before internal ones when generating `tsconfig.json` #31882

coderabbitai bot commented Apr 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Apr 23, 2025 •

edited

Loading

codspeed-hq bot commented Apr 23, 2025 •

edited

Loading