-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
docs: use emphasis instead of quotes #32078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe changes update documentation in the "getting started" and "going further" sections by removing the commented-out configuration line Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/1.getting-started/18.upgrade.md (1)
664-664
: Clarity: simplify the phrasing for improved readability.
The current sentence is accurate but a bit verbose. Consider streamlining and using parallel structure, for example:`refresh({ dedupe: false })` means **do not _cancel_ existing requests in favour of this new one**, while `refresh({ dedupe: true })` means **do not initiate a new request if one is already pending**.This keeps the emphasis consistent and reduces cognitive load.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/1.getting-started/18.upgrade.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: lint-docs
777af56
to
f47af14
Compare
🔗 Linked issue
📚 Description
before:
after:
Emmm.. I also find some config is not used? Like
resetAsyncDataToUndefined|compileTemplate|templateUtils|relativeWatchPaths
, is these should removed?