fix(vite): do not replace `global` with `globalThis` #32130

danielroe · 2025-05-16T16:30:13Z

🔗 Linked issue

resolves #32127

📚 Description

previously, we added this workaround (nuxt/framework#4958) to resolve #13941 and help resolve issues with dependencies that used CJS (#12830).

I think we might be able to drop it now. #13941 is no longer reproducible with the current version of Vite.

(Note that Nitro will also do the same thing though, so this might not totally resolve the issue.)

bolt-new-by-stackblitz · 2025-05-16T16:30:17Z

Run & review this pull request in StackBlitz Codeflow.

Copilot

Pull Request Overview

This PR removes the legacy workaround that replaced "global" with "globalThis" in the Vite configuration, as the underlying issue is no longer reproducible with the current Vite version.

Removed the plugin call that performed the global replacement
Deleted the globalThisReplacements variable definition since it is no longer needed

coderabbitai · 2025-05-16T16:31:54Z

Walkthrough

The change removes the replace plugin configured with globalThisReplacements from the plugins array in the bundle function within the Vite configuration. The constant globalThisReplacements, which mapped certain global. identifiers to globalThis. equivalents, is also deleted. Additionally, a new Nuxt template named globalPolyfillsTemplate was added to generate a global-polyfills.mjs file that polyfills the global object on globalThis if missing. Correspondingly, the Nuxt app entry file imports this new polyfill module alongside an existing fetch polyfill. No other modifications are made to the build configuration, control flow, or exported entities. Other plugin usages, including additional replace plugins added in the vite:extendConfig hook, remain unaffected.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b95d8e and 6b9106a.

📒 Files selected for processing (2)

packages/nuxt/src/app/entry.ts (1 hunks)
packages/nuxt/src/core/templates.ts (1 hunks)

✅ Files skipped from review due to trivial changes (2)

packages/nuxt/src/app/entry.ts
packages/nuxt/src/core/templates.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: codeql (javascript-typescript)
GitHub Check: build
GitHub Check: code

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch fix/global-this
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-05-16T16:33:43Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32130

nuxt

npm i https://pkg.pr.new/nuxt@32130

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32130

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32130

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32130

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32130

commit: 6b9106a

codspeed-hq · 2025-05-16T16:43:52Z

CodSpeed Performance Report

Merging #32130 will not alter performance

_{Comparing fix/global-this (6b9106a) with main (c0a518f)}

Summary

✅ 10 untouched benchmarks

pi0 · 2025-05-17T08:46:38Z

nitrojs/nitro#3364

For Nuxt Client builds, you might also add (this) to entry since any lib might be working because of this and will be broken without in browser.

fix(vite): do not replace global with globalThis

4b95d8e

danielroe requested review from pi0 and Copilot May 16, 2025 16:30

github-actions bot added 3.x bug labels May 16, 2025

Copilot AI reviewed May 16, 2025

View reviewed changes

pi0 mentioned this pull request May 17, 2025

fix: depend on unenv global. polyfill nitrojs/nitro#3364

Merged

danielroe added 2 commits May 17, 2025 12:16

fix: polyfill global. in entry

c39a3b2

Merge remote-tracking branch 'origin/main' into fix/global-this

6b9106a

danielroe merged commit 146acb7 into main May 17, 2025
46 checks passed

danielroe deleted the fix/global-this branch May 17, 2025 11:00

danielroe added a commit that referenced this pull request May 17, 2025

fix(vite): do not replace global with globalThis (#32130)

a7b8db9

This was referenced May 17, 2025

v4.0.0 #27716

Merged

v3.17.4 #32106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(vite): do not replace `global` with `globalThis` #32130

fix(vite): do not replace `global` with `globalThis` #32130

Uh oh!

danielroe commented May 16, 2025

Uh oh!

bolt-new-by-stackblitz bot commented May 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot commented May 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 16, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 16, 2025 •

edited

Loading

Uh oh!

pi0 commented May 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

fix(vite): do not replace global with globalThis #32130

fix(vite): do not replace global with globalThis #32130

Uh oh!

Conversation

danielroe commented May 16, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented May 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

coderabbitai bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #32130 will not alter performance

Summary

Uh oh!

pi0 commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix(vite): do not replace `global` with `globalThis` #32130

fix(vite): do not replace `global` with `globalThis` #32130

coderabbitai bot commented May 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented May 16, 2025 •

edited

Loading

codspeed-hq bot commented May 16, 2025 •

edited

Loading

pi0 commented May 17, 2025 •

edited

Loading