fix(kit): do not double-urlify file urls when resolving schema #32354

danielroe · 2025-06-10T11:34:05Z

🔗 Linked issue

resolves #32311

📚 Description

we were wrongly converting file URLs to file URLs, meaning nuxt/schema wasn't being resolved from within the nuxt directory.

bolt-new-by-stackblitz · 2025-06-10T11:34:07Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-06-10T11:35:40Z

Walkthrough

The import of pathToFileURL from 'node:url' was removed. In the loadNuxtSchema function, the urls array was explicitly typed as Array<URL | string>. The logic for adding the Nuxt module path to the urls array was changed: previously, the Nuxt path was converted to a file URL using pathToFileURL before being unshifted; now, the raw nuxtPath (which may be a string or URL) is directly unshifted without conversion. No changes were made to the signatures or declarations of exported or public entities. The rest of the function and related logic remain unchanged.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67c04eb and 2c05c7e.

📒 Files selected for processing (1)

packages/kit/src/loader/config.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/kit/src/loader/config.ts

⏰ Context from checks skipped due to timeout of 90000ms (20)

GitHub Check: test-fixtures (windows-latest, built, webpack, default, manifest-on, json, 20)
GitHub Check: test-fixtures (windows-latest, built, vite, async, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, rspack, default, manifest-on, json, 20)
GitHub Check: test-fixtures (windows-latest, dev, vite, async, manifest-off, json, 20)
GitHub Check: test-fixtures (windows-latest, dev, vite, async, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, webpack, async, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, webpack, default, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, rspack, async, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, async, manifest-off, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, async, manifest-on, js, 20)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, default, manifest-off, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-off, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-off, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, default, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, built, vite, async, manifest-on, json, 20)
GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-on, json, 20)
GitHub Check: test-benchmark
GitHub Check: typecheck (windows-latest, bundler)
GitHub Check: typecheck (ubuntu-latest, bundler)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/kit/src/loader/config.ts (1)

11-11: Remove unused resolveModulePath import
The resolveModulePath symbol is imported but never used in this module. Consider removing it to reduce dead code and improve clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a14e790 and 67c04eb.

📒 Files selected for processing (1)

packages/kit/src/loader/config.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: codeql (actions)
GitHub Check: codeql (javascript-typescript)
GitHub Check: build
GitHub Check: code

🔇 Additional comments (2)

packages/kit/src/loader/config.ts (2)

126-126: Explicit union type for urls improves clarity
Typing urls as Array<URL | string> clearly documents that it may contain both file URLs and raw paths.

129-129: Prevent double-urlification by unshifting raw nuxtPath
Directly adding nuxtPath fixes the double-URL conversion bug. Please verify that resolveModuleURL accepts an array for its from option to guarantee proper schema resolution.

Copilot

Pull Request Overview

This PR fixes an issue where file URLs were being converted twice when resolving @nuxt/schema, causing resolution failures within the Nuxt directory.

Added resolveModulePath import and adjusted module URL resolution logic
Changed urls array to accept both URL and string types
Removed redundant pathToFileURL conversion for already-resolved module paths

Comments suppressed due to low confidence (1)

packages/kit/src/loader/config.ts:127

Add a unit test to cover both string and URL inputs for loadNuxtSchema, ensuring file URLs are not double-urlified when resolving @nuxt/schema.

const nuxtPath = resolveModuleURL('nuxt', { try: true, from: url })

packages/kit/src/loader/config.ts

pkg-pr-new · 2025-06-10T11:37:49Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32354

nuxt

npm i https://pkg.pr.new/nuxt@32354

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32354

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32354

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32354

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32354

commit: 2c05c7e

codspeed-hq · 2025-06-10T11:52:15Z

CodSpeed Performance Report

Merging #32354 will not alter performance

_{Comparing fix/resolve-schema (2c05c7e) with main (a14e790)}

Summary

✅ 10 untouched benchmarks

fix(kit): do not double-urlify file urls when resolving schema

67c04eb

Copilot AI review requested due to automatic review settings June 10, 2025 11:34

github-actions bot added 3.x bug labels Jun 10, 2025

coderabbitai bot reviewed Jun 10, 2025

View reviewed changes

Copilot AI reviewed Jun 10, 2025

View reviewed changes

packages/kit/src/loader/config.ts Outdated Show resolved Hide resolved

packages/kit/src/loader/config.ts Show resolved Hide resolved

chore: remove unused imports

2c05c7e

danielroe merged commit 0f7d877 into main Jun 10, 2025
117 of 120 checks passed

danielroe deleted the fix/resolve-schema branch June 10, 2025 12:45

github-actions bot mentioned this pull request Jun 10, 2025

v4.0.0 #27716

Merged

This was referenced Jun 30, 2025

nuxt-4 (canary) Test Failed getsentry/sentry-javascript#16762

Closed

test(nuxt): Remove external config getsentry/sentry-javascript#16775

Closed

danielroe added a commit that referenced this pull request Jul 1, 2025

fix(kit): do not double-urlify file urls when resolving schema (#32354)

34a8134

github-actions bot mentioned this pull request Jul 1, 2025

v3.17.6 #32346

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(kit): do not double-urlify file urls when resolving schema #32354

fix(kit): do not double-urlify file urls when resolving schema #32354

Uh oh!

danielroe commented Jun 10, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Jun 10, 2025

Uh oh!

coderabbitai bot commented Jun 10, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

fix(kit): do not double-urlify file urls when resolving schema #32354

fix(kit): do not double-urlify file urls when resolving schema #32354

Uh oh!

Conversation

danielroe commented Jun 10, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jun 10, 2025

Uh oh!

coderabbitai bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jun 10, 2025

CodSpeed Performance Report

Merging #32354 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

coderabbitai bot commented Jun 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jun 10, 2025 •

edited

Loading