-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: bump node requirement >=18.0.0
#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- package.json: Language not supported
🦋 Changeset detectedLatest commit: e7ec90d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I just added cc @ota-meshi |
I think we can drop support for Node.js<v20. What do you think about doing that instead? |
@ota-meshi I think supporting legacy versions won't require many efforts, then we can still support them. Ending of LTS doesn't mean no one is using that immediately. But considering #130, I think maybe |
synckit
>=18.0.0
@ota-meshi Is |
Let's move on! |
@@ -3,7 +3,7 @@ | |||
"version": "0.13.1", | |||
"description": "ESLint plugin to check Node.js dependencies.", | |||
"engines": { | |||
"node": ">=14.17.0" | |||
"node": ">=18.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we can use v12 of npm-package-arg if we tighten the requirements.
"node": ">=18.0.0" | |
"node": "^18.17.0 || >=20.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, should we? I'm both fine with that. Another PR on the way.
@@ -103,10 +103,10 @@ | |||
}, | |||
"dependencies": { | |||
"jsonc-eslint-parser": "^2.0.2", | |||
"npm-package-arg": "^10.1.0 || ^11.0.3 || ^12.0.2", | |||
"npm-package-arg": "^11.0.3 || ^12.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"npm-package-arg": "^11.0.3 || ^12.0.2", | |
"npm-package-arg": "^12.0.2", |
No description provided.