Skip to content

chore: bump node requirement >=18.0.0 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

chore: bump node requirement >=18.0.0 #174

merged 2 commits into from
May 1, 2025

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented May 1, 2025

No description provided.

@JounQin JounQin requested review from ota-meshi and Copilot May 1, 2025 06:52
@JounQin JounQin self-assigned this May 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • package.json: Language not supported

Copy link

changeset-bot bot commented May 1, 2025

🦋 Changeset detected

Latest commit: e7ec90d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-node-dependencies Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JounQin
Copy link
Collaborator Author

JounQin commented May 1, 2025

Error:   106:5  error  "npm-package-arg@^10.1.0 || ^11.0.3 || ^12.0.2" is not compatible with "node@^14.18.0||>=16.0.0". Allowed is: "node@^14.17.0||^16.13.0||>=18.0.0"  node-dependencies/compat-engines

Oh, no.

I just added npm-package-arg@^9.1.2 as fallback.

cc @ota-meshi

@ota-meshi
Copy link
Owner

I think we can drop support for Node.js<v20. What do you think about doing that instead?

@JounQin
Copy link
Collaborator Author

JounQin commented May 1, 2025

I think we can drop support for Node.js<v20. What do you think about doing that instead?

@ota-meshi I think supporting legacy versions won't require many efforts, then we can still support them. Ending of LTS doesn't mean no one is using that immediately.

But considering #130, I think maybe >=18.0.0 is fine enough?

@JounQin JounQin changed the title chore: bump node requirement same as synckit chore: bump node requirement >=18.0.0 May 1, 2025
@JounQin
Copy link
Collaborator Author

JounQin commented May 1, 2025

@ota-meshi Is >=18.0.0 fine for you?

@JounQin
Copy link
Collaborator Author

JounQin commented May 1, 2025

Let's move on!

@JounQin JounQin merged commit 49f0a5f into main May 1, 2025
7 checks passed
@JounQin JounQin deleted the chore/bump branch May 1, 2025 07:46
@@ -3,7 +3,7 @@
"version": "0.13.1",
"description": "ESLint plugin to check Node.js dependencies.",
"engines": {
"node": ">=14.17.0"
"node": ">=18.0.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we can use v12 of npm-package-arg if we tighten the requirements.

Suggested change
"node": ">=18.0.0"
"node": "^18.17.0 || >=20.5.0"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, should we? I'm both fine with that. Another PR on the way.

@@ -103,10 +103,10 @@
},
"dependencies": {
"jsonc-eslint-parser": "^2.0.2",
"npm-package-arg": "^10.1.0 || ^11.0.3 || ^12.0.2",
"npm-package-arg": "^11.0.3 || ^12.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"npm-package-arg": "^11.0.3 || ^12.0.2",
"npm-package-arg": "^12.0.2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy