Skip to content

refactor(linter): simplify implementation of eslint/no-lonely-if #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

refactor(linter): simplify implementation of eslint/no-lonely-if #11550

merged 1 commit into from
Jun 10, 2025

Conversation

ulrichstark
Copy link
Contributor

No description provided.

@ulrichstark ulrichstark requested a review from camc314 as a code owner June 7, 2025 19:30
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 7, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 7, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11550 will create unknown performance changes

Comparing ulrichstark:refactor-no-lonely-if-to-shorten-code (f10707b) with main (d41fb13)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.4 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.9 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 302.2 µs N/A
🆕 formatter[binder.ts] N/A 19.4 ms N/A
🆕 formatter[cal.com.tsx] N/A 150.8 ms N/A
🆕 formatter[react.development.js] N/A 9.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21 µs N/A
🆕 lexer[binder.ts] N/A 929.5 µs N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[react.development.js] N/A 383.8 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[binder.ts] N/A 149.2 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[react.development.js] N/A 54.7 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.3 µs N/A
🆕 mangler[binder.ts] N/A 807.3 µs N/A
🆕 mangler[cal.com.tsx] N/A 3.1 ms N/A
🆕 mangler[react.development.js] N/A 284.1 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@ulrichstark ulrichstark changed the title refactor(linter): shorten implementation of eslint/no-lonely-if refactor(linter): simplify implementation of eslint/no-lonely-if Jun 7, 2025
camc314
camc314 reviewed Jun 8, 2025
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, will merge after 1.0 thanks

@camc314 camc314 marked this pull request as draft June 8, 2025 10:12
@camc314 camc314 self-assigned this Jun 8, 2025
@camc314 camc314 marked this pull request as ready for review June 10, 2025 13:40
@camc314 camc314 force-pushed the refactor-no-lonely-if-to-shorten-code branch from 1b9dcc7 to f10707b Compare June 10, 2025 13:40
@camc314 camc314 merged commit d29bbb2 into oxc-project:main Jun 10, 2025
23 checks passed
@ulrichstark ulrichstark deleted the refactor-no-lonely-if-to-shorten-code branch June 10, 2025 14:59
@oxc-bot oxc-bot mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 left review comments

Assignees

@camc314 camc314

Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulrichstark @camc314
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy