Skip to content

fix(linter/extensions): false positives with non configured extensions #11872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jun 23, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jun 23, 2025
Copy link
Contributor Author

camc314 commented Jun 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review June 23, 2025 21:48
Copy link

codspeed-hq bot commented Jun 23, 2025

CodSpeed Instrumentation Performance Report

Merging #11872 will not alter performance

Comparing c/06-23-fix_linter_extensions_false_positives_with_non_configured_extensions (dd6b1ee) with main (5b99cad)

Summary

✅ 38 untouched benchmarks

@Sysix
Copy link
Member

Sysix commented Jun 24, 2025

I do not understand why the option ignorePackages is needed.

If it is the string "ignorePackages", then the rule enforces the use of extensions for all import statements except package imports.

The imports are relative paths. I think we need to enable this test too, to fix the bug:
//github.com/oxc-project/oxc/blob/40e6a6e4216fba3c981fb91eb877740b48a1b802/crates/oxc_linter/src/rules/import/extensions.rs#L385-L395

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
Copy link
Member

Boshen commented Jul 3, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-23-fix_linter_extensions_false_positives_with_non_configured_extensions branch from 40e6a6e to dd6b1ee Compare July 3, 2025 07:33
@graphite-app graphite-app bot merged commit dd6b1ee into main Jul 3, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/06-23-fix_linter_extensions_false_positives_with_non_configured_extensions branch July 3, 2025 07:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@oxc-bot oxc-bot mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy