Skip to content

perf(linter): replace unicode-segmentation crate with icu_segmenter #12063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

perf(linter): replace unicode-segmentation crate with icu_segmenter #12063

merged 1 commit into from
Jul 3, 2025

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Jul 3, 2025 •
edited
Loading

grafik

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Jul 3, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Jul 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 3, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12063 will not alter performance

Comparing 07-03-perf_linter_replace_unicode-segmentation_crate_with_icu_ (62a3ce0) with main (a7e9f50)

Summary

✅ 38 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review July 3, 2025 19:55
@Sysix Sysix requested a review from camc314 as a code owner July 3, 2025 19:55
@Sysix Sysix force-pushed the 07-03-perf_linter_replace_unicode-segmentation_crate_with_icu_ branch from 22eee2a to 9f40c53 Compare July 3, 2025 21:17
@Sysix Sysix changed the title perf(linter): replace unicode-segmentation crate with icu perf(linter): replace unicode-segmentation crate with icu_segmenter Jul 3, 2025
@Sysix Sysix force-pushed the 07-03-perf_linter_replace_unicode-segmentation_crate_with_icu_ branch from 9f40c53 to b227417 Compare July 3, 2025 21:18
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Jul 3, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 07-03-perf_linter_replace_unicode-segmentation_crate_with_icu_ branch from b227417 to 62a3ce0 Compare July 3, 2025 21:29
@graphite-app graphite-app bot merged commit 62a3ce0 into main Jul 3, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@graphite-app graphite-app bot deleted the 07-03-perf_linter_replace_unicode-segmentation_crate_with_icu_ branch July 3, 2025 21:37
@oxc-bot oxc-bot mentioned this pull request Jul 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sysix @camc314
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy