Skip to content

refactor(linter): RuntimeFileSystem::write_file take &str #12075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

refactor(linter): RuntimeFileSystem::write_file take &str #12075

merged 1 commit into from
Jul 4, 2025
+5 −5

Conversation

overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 4, 2025 •
edited
Loading

Pure refactor. It's unnecessary for RuntimeFileSystem::write_file to receive an owned String. It can just take a &str slice.

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 4, 2025
@overlookmotel Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 4, 2025 11:15
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 4, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12075 will not alter performance

Comparing 07-04-refactor_linter_runtimefilesystem_write_file_take_str_ (72418ca) with main (2f7cbda)

Summary

✅ 38 untouched benchmarks

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 4, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Jul 4, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(linter): RuntimeFileSystem::write_file take &str (#12075)
72418ca 
Pure refactor. It's unnecessary for `RuntimeFileSystem::write_file` to receive an owned `String`. It can just take a `&str` slice.
@graphite-app graphite-app bot force-pushed the 07-04-refactor_linter_runtimefilesystem_write_file_take_str_ branch from a1fec4d to 72418ca Compare July 4, 2025 12:01
@graphite-app graphite-app bot merged commit 72418ca into main Jul 4, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 4, 2025
@graphite-app graphite-app bot deleted the 07-04-refactor_linter_runtimefilesystem_write_file_take_str_ branch July 4, 2025 12:05
@oxc-bot oxc-bot mentioned this pull request Jul 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sysix Sysix Sysix approved these changes

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees
No one assigned
Labels
A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@overlookmotel @camc314 @Sysix
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy