perf(linter): avoid iteration when checking import is AllButDefault or SideEffect in eslint/no-duplicate-imports
#12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12093 will degrade performances by 13.32%Comparing Summary
Benchmarks breakdown
|
Merge activity
|
… or `SideEffect` in `eslint/no-duplicate-imports` (#12093) Avoid the 3 iterations ``` let namespace = existing.iter().find(|(t, _, _)| matches!(t, ImportType::Namespace)); let named = existing.iter().find(|(t, _, _)| matches!(t, ImportType::Named)); let default = existing.iter().find(|(t, _, _)| matches!(t, ImportType::Default)); ``` when the `ImportType` is `SideEffect` or `AllButDefault`. Their results are not needed for the two types.
1793659 to
04e2de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the 3 iterations
when the
ImportTypeisSideEffectorAllButDefault. Their results are not needed for the two types.