fix(object-hasher): switch to object-hash to fix hashing of large objects #7591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d990f3 to
d4af3df
Compare
jakebailey
commented
Jan 29, 2024
| @@ -1,13 +1,25 @@ | |||
| import { hashObject, hashObjectWithoutSorting } from '@pnpm/crypto.object-hasher' | |||
|
|
|||
| describe('hashObject', () => { | |||
| const hash = hashObject | |||
There was a problem hiding this comment.
This is just to make copy/pasting tests easier. I made mistakes while writing the tests until I realized I was testing the wrong function.
jakebailey
commented
Jan 29, 2024
| @@ -18154,5 +18161,7 @@ packages: | |||
| dev: false | |||
|
|
|||
| time: | |||
| /@types/object-hash@3.0.6: '2023-11-07T12:14:41.852Z' | |||
There was a problem hiding this comment.
I... don't know why these are showing up in the lockfile?
zkochan
approved these changes
Jan 29, 2024
|
🚢 8.15.1 |
|
Thank you! |
zkochan
added a commit
to teambit/bit
that referenced
this pull request
Jan 31, 2024
## Proposed Changes - pnpm/pnpm#7583 - pnpm/pnpm#7563 - pnpm/pnpm#7591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7563 (comment)
Marked this as a major bump given the hash values are changing.
Adds some more tests too;
object-hashcannot hashundefined, so I just made it return0. Feel free to suggest something better.