Skip to content

refactor(FormControl): update to CSS Modules behind feature flag #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 11, 2024
Merged

refactor(FormControl): update to CSS Modules behind feature flag #5370

merged 11 commits into from
Dec 11, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Dec 5, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3812

Changelog

New

Changed

  • Update FormControl and shared internal components to use form control behind feature flag

Removed

Rollout strategy

  • Minor release

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6491edb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5370 December 5, 2024 23:03 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.07 KB (+0.34% 🔺)
packages/react/dist/browser.umd.js 103.44 KB (+0.29% 🔺)

langermank
langermank reviewed Dec 6, 2024
View reviewed changes
@joshblack @langermank
Apply suggestions from code review
a944165 
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-5370 December 6, 2024 00:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5370 December 6, 2024 17:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5370 December 6, 2024 17:06 Inactive
@joshblack joshblack marked this pull request as ready for review December 9, 2024 16:08
@joshblack joshblack requested a review from a team as a code owner December 9, 2024 16:08
@github-actions github-actions bot temporarily deployed to storybook-preview-5370 December 9, 2024 16:17 Inactive
jonrohan
jonrohan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, here we go 🎉

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354624

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 11, 2024
@joshblack joshblack added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 204ded0 Dec 11, 2024
42 checks passed
@joshblack joshblack deleted the refactor/update-form-control-to-css-modules-3 branch December 11, 2024 18:13
@primer primer bot mentioned this pull request Dec 11, 2024
Merged
francinelucca added a commit that referenced this pull request Dec 13, 2024
@francinelucca
Revert "refactor(FormControl): update to CSS Modules behind feature f…
29cbdd9 
…lag (#5370)"

This reverts commit 204ded0.
@francinelucca francinelucca mentioned this pull request Dec 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2024
@francinelucca
Revert #5370, #5349 due to visual regressions (#5434)
da7debd 
* Revert "refactor(FormControl): update to CSS Modules behind feature flag (#5370)"

This reverts commit 204ded0.

* Revert "refactor(Table): update to CSS Modules (#5349)"

This reverts commit 2c79798.

* Create healthy-eggs-pretend.md
@joshblack joshblack restored the refactor/update-form-control-to-css-modules-3 branch December 13, 2024 16:09
@joshblack joshblack deleted the refactor/update-form-control-to-css-modules-3 branch December 13, 2024 16:09
@joshblack joshblack restored the refactor/update-form-control-to-css-modules-3 branch December 13, 2024 17:18
@github-actions github-actions bot temporarily deployed to storybook-preview-5438 December 13, 2024 17:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank

Assignees
No one assigned
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @jonrohan @langermank
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy