Skip to content

DialogV2: Add alpha status to docs #5706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2025
Merged

DialogV2: Add alpha status to docs #5706

merged 6 commits into from
Mar 10, 2025

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Feb 18, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4749

We should promote DialogV2 to alpha status in the Primer docs. We have already accomplished most of the work in v37, this ensures that the component has the correct status in our docs.

Changelog

Changed

  • Changed status draft to alpha
  • Move DialogV1 to deprecated stories in Storybook

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 12a08a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.01 KB (0%)
packages/react/dist/browser.umd.js 106.29 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5706 February 18, 2025 17:14 Inactive
@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Feb 18, 2025
@TylerJDev TylerJDev marked this pull request as ready for review February 18, 2025 17:42
@TylerJDev TylerJDev requested a review from a team as a code owner February 18, 2025 17:42
@TylerJDev TylerJDev requested a review from langermank February 18, 2025 17:42
@github-actions github-actions bot temporarily deployed to storybook-preview-5706 February 18, 2025 18:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5706 February 22, 2025 14:03 Inactive
@primer primer bot requested a review from a team as a code owner February 22, 2025 14:28
@primer primer bot temporarily deployed to github-pages February 22, 2025 14:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5706 February 22, 2025 14:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5706 February 22, 2025 14:56 Inactive
@TylerJDev
Copy link
Member Author

With #5740 being merged, we can go ahead and merge this too! The status will be reflected after our next release, which will also include a fix that closes out the remaining Dialog accessibility issues.

@TylerJDev TylerJDev added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 9324036 Mar 10, 2025
44 checks passed
@TylerJDev TylerJDev deleted the promote-dialog-to-alpha branch March 10, 2025 14:43
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@TylerJDev @jonrohan @hectahertz
DialogV2: Add alpha status to docs (#5706)
cea07bf 
Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerJDev @joshblack @jonrohan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy