Skip to content

Remove DialogV1 story broken link #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

Remove DialogV1 story broken link #5902

merged 5 commits into from
Apr 18, 2025

Conversation

hectahertz
Copy link
Contributor

Changelog

Changed

This removes the link from the DialogV1 story, as it was broken anyway.

Before:

Screenshot 2025-04-08 at 11 26 55

After:

Screenshot 2025-04-08 at 11 27 00

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Tested locally

Merge checklist

@hectahertz hectahertz requested a review from a team as a code owner April 8, 2025 09:27
@hectahertz hectahertz requested a review from TylerJDev April 8, 2025 09:27
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 75a6d8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Uh oh! @hectahertz, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 13
  • Images should have meaningful alternative text (alt text) at line 18

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.7 KB (0%)
packages/react/dist/browser.umd.js 102.99 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5902 April 8, 2025 09:41 Inactive
@primer primer bot requested a review from a team as a code owner April 8, 2025 13:11
@primer primer bot requested a review from tbenning April 8, 2025 13:11
@github-actions github-actions bot temporarily deployed to storybook-preview-5902 April 8, 2025 13:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5902 April 8, 2025 17:01 Inactive
@hectahertz hectahertz enabled auto-merge April 14, 2025 17:57
@hectahertz hectahertz added this pull request to the merge queue Apr 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 14, 2025
@hectahertz hectahertz added this pull request to the merge queue Apr 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@hectahertz hectahertz added this pull request to the merge queue Apr 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2025
@hectahertz @francinelucca
Remove DialogV1 story broken link (#5902)
8ce2ed2 
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025
@hectahertz hectahertz added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit c9659fd Apr 18, 2025
44 checks passed
@hectahertz hectahertz deleted the hectahertz/fix-dialog-broken-link branch April 18, 2025 15:25
@primer primer bot mentioned this pull request Apr 18, 2025
Merged
hectahertz added a commit that referenced this pull request May 20, 2025
@hectahertz @francinelucca
Remove DialogV1 story broken link (#5902)
92c499a 
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilybrick emilybrick emilybrick approved these changes

@TylerJDev TylerJDev TylerJDev approved these changes

@tbenning tbenning Awaiting requested review from tbenning tbenning is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hectahertz @emilybrick @TylerJDev @francinelucca
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy