Skip to content

fix(SelectPanel): disable body scroll on full screen #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

fix(SelectPanel): disable body scroll on full screen #5904

merged 4 commits into from
Apr 8, 2025

Conversation

francinelucca
Copy link
Member

Disables body scroll when SelectPanel is open on full screen mode. Fixes bug where the document scroll bar was clipping the TextInput. Page scrolling shouldn't have been enabled in the first place.

Changelog

New

  • Detect narrow screen size in SelectPanel and disable body scroll if the FullScreen FF is turned on

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner April 8, 2025 13:33
@francinelucca francinelucca requested a review from jonrohan April 8, 2025 13:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 985b6ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 8, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.35 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 104.74 KB (-0.01% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371871

@github-actions github-actions bot temporarily deployed to storybook-preview-5904 April 8, 2025 13:46 Inactive
hectahertz
hectahertz approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could handle it some other way, but probably we'd need more control of the page structure for that. Let's merge this for now.

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 8, 2025
@francinelucca francinelucca enabled auto-merge April 8, 2025 14:46
@francinelucca
empty commit
a6cdfda
@francinelucca
Merge branch 'fix/disable-body-scroll-on-select-panel-full-screen' of…
985b6ad 
… github.com:primer/react into fix/disable-body-scroll-on-select-panel-full-screen
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5904 April 8, 2025 15:05 Inactive
@francinelucca francinelucca added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit a522fdb Apr 8, 2025
71 of 73 checks passed
@francinelucca francinelucca deleted the fix/disable-body-scroll-on-select-panel-full-screen branch April 8, 2025 16:25
@primer primer bot mentioned this pull request Apr 8, 2025
Merged
jonrohan pushed a commit that referenced this pull request Apr 10, 2025
@francinelucca @jonrohan
fix(SelectPanel): disable body scroll on full screen (#5904)
f8daa7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectahertz hectahertz hectahertz approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francinelucca @hectahertz
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy