-
Notifications
You must be signed in to change notification settings - Fork 622
docs: add css layers adr #5916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add css layers adr #5916
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the idea! Just one comment
I'd love to be able to just code the css without having to worry about the where()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this fit with the current @primer-react
layer in dotcom?
Could we do something like this, so we could define in dotcom the priority of the layers for all primer? @layer primer-css-base, primer, recipes;
@layer primer {
@layer components {
@layer ComponentName {
....
}
}
}
@jonrohan I bet we could remove the layer upstream now that our stuff could be reliably in a layer. Thankfully I think even if we do no change it should still be okay.
And yeah! I think so. That's probably one of the nicest parts about this is that we could also have our own internal logic too for ordering of components (like links always come after breadcrumbs) |
Add ADR talking about our usage of
:where()
and how we could use CSS layers to accomplish a similar goal.Curious to hear what you all think! Let me know if you have any comments/questions 👀
Changelog
New
Changed
Removed