Skip to content

docs: add css layers adr #5916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025
Merged

docs: add css layers adr #5916

merged 6 commits into from
Apr 30, 2025

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Apr 11, 2025

Add ADR talking about our usage of :where() and how we could use CSS layers to accomplish a similar goal.

Curious to hear what you all think! Let me know if you have any comments/questions 👀

Changelog

New

  • Add ADR for CSS layers

Changed

Removed

Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: a133be8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 11, 2025
@joshblack joshblack added the skip changeset This change does not need a changelog label Apr 11, 2025
Copy link
Contributor

github-actions bot commented Apr 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.81 KB (0%)
packages/react/dist/browser.umd.js 99.1 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5916 April 11, 2025 16:30 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5916 April 11, 2025 16:48 Inactive
@joshblack joshblack marked this pull request as ready for review April 15, 2025 16:21
@joshblack joshblack requested a review from a team as a code owner April 15, 2025 16:21
@joshblack joshblack requested a review from jonrohan April 15, 2025 16:21
@github-actions github-actions bot temporarily deployed to storybook-preview-5916 April 15, 2025 16:40 Inactive
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea! Just one comment

I'd love to be able to just code the css without having to worry about the where()

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this fit with the current @primer-react layer in dotcom?

Could we do something like this, so we could define in dotcom the priority of the layers for all primer? @layer primer-css-base, primer, recipes;

@layer primer {
  @layer components {
     @layer ComponentName {
          ....
      }
   }
}

@joshblack
Copy link
Member Author

@jonrohan I bet we could remove the layer upstream now that our stuff could be reliably in a layer. Thankfully I think even if we do no change it should still be okay.

Could we do something like this, so we could define in dotcom the priority of the layers for all primer?

And yeah! I think so. That's probably one of the nicest parts about this is that we could also have our own internal logic too for ordering of components (like links always come after breadcrumbs)

@joshblack joshblack requested a review from jonrohan April 22, 2025 17:41
@joshblack joshblack added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit c359028 Apr 30, 2025
45 checks passed
@joshblack joshblack deleted the docs/add-css-layers-adr branch April 30, 2025 18:57
hectahertz pushed a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy