Skip to content

chore(PageHeader): Remove the CSS modules feature flag from the PageHeader component #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

chore(PageHeader): Remove the CSS modules feature flag from the PageHeader component #5877

merged 5 commits into from
Apr 14, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 4, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4300

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the PageHeader component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f3e0c80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.76 KB (-0.65% 🔽)
packages/react/dist/browser.umd.js 104.06 KB (-0.7% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5877 April 4, 2025 02:51 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 4, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5877 April 4, 2025 23:40 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-5877 April 8, 2025 23:16 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5877 April 8, 2025 23:29 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371377

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 10, 2025
@jonrohan jonrohan marked this pull request as ready for review April 10, 2025 18:15
@jonrohan jonrohan requested a review from a team as a code owner April 10, 2025 18:15
@jonrohan jonrohan requested review from TylerJDev and joshblack April 10, 2025 18:15
@jonrohan jonrohan enabled auto-merge April 11, 2025 18:17
@jonrohan jonrohan added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 8a7d583 Apr 14, 2025
46 checks passed
@jonrohan jonrohan deleted the remove_css_modules_flag_pageheader branch April 14, 2025 16:03
@primer primer bot mentioned this pull request Apr 14, 2025
Merged
hectahertz pushed a commit that referenced this pull request May 20, 2025
@jonrohan @hectahertz
chore(PageHeader): Remove the CSS modules feature flag from the PageH…
33f7301 
…eader component (#5877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @langermank
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy