Skip to content

Adding margin around notice styles #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 5, 2025

Conversation

emilybrick
Copy link
Contributor

@emilybrick emilybrick commented Apr 4, 2025

Changelog

New

Changed

Adds a margin around the notice in the SelectPanel so that the message is not full-width.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@emilybrick emilybrick requested a review from a team as a code owner April 4, 2025 18:15
@emilybrick emilybrick requested a review from francinelucca April 4, 2025 18:15
Copy link

changeset-bot bot commented Apr 4, 2025

🦋 Changeset detected

Latest commit: 4a0252e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 4, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 4, 2025
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

github-actions bot commented Apr 4, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.47 KB (0%)
packages/react/dist/browser.umd.js 104.91 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5881 April 4, 2025 18:21 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5881 April 4, 2025 18:34 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-5881 April 4, 2025 19:17 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5881 April 4, 2025 19:31 Inactive
@primer primer bot requested a review from a team as a code owner April 4, 2025 19:48
@primer primer bot requested a review from mperrotti April 4, 2025 19:48
@github-actions github-actions bot temporarily deployed to storybook-preview-5881 April 4, 2025 20:02 Inactive
@francinelucca francinelucca enabled auto-merge April 4, 2025 20:49
@francinelucca francinelucca disabled auto-merge April 4, 2025 20:50
…primer/react into emilybrick/fix-width-selectpanel-notice
@francinelucca francinelucca added this pull request to the merge queue Apr 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2025
@francinelucca francinelucca added this pull request to the merge queue Apr 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2025
@francinelucca francinelucca added this pull request to the merge queue Apr 5, 2025
Merged via the queue into main with commit ea1fb50 Apr 5, 2025
50 checks passed
@francinelucca francinelucca deleted the emilybrick/fix-width-selectpanel-notice branch April 5, 2025 03:37
@primer primer bot mentioned this pull request Apr 4, 2025
jonrohan pushed a commit that referenced this pull request Apr 10, 2025
Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: Marie Lucca <francinelucca@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy