Skip to content

Only render a footer border on Dialogs with a scrolling body #5897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 29, 2025
Merged

Only render a footer border on Dialogs with a scrolling body #5897

merged 9 commits into from
May 29, 2025

Conversation

mperrotti
Copy link
Contributor

Closes https://github.com/github/primer/issues/4989

Kapture.2025-04-07.at.15.12.53.mp4

Changelog

New

Changed

  • Only render a border between the dialog body and the dialog footer in browsers that support CSS animation-timeline and its scroll() function

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner April 7, 2025 19:17
@mperrotti mperrotti requested a review from hectahertz April 7, 2025 19:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c7d5cf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.36 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 94.55 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5897 April 7, 2025 19:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5897 April 9, 2025 13:53 Inactive
@mperrotti mperrotti changed the title Only render a footer border on dialogs with a scrolling body Only render a footer border on Dialogs with a scrolling body Apr 9, 2025
hectahertz
hectahertz approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved the implementation! 🚀

@github-actions github-actions bot temporarily deployed to storybook-preview-5897 April 10, 2025 14:02 Inactive
@lesliecdubs
Copy link
Member

👋🏻 @mperrotti friendly reminder about this one, looks like it's almost ready to go once the conflict is resolved!

@github-actions github-actions bot requested a deployment to storybook-preview-5897 May 28, 2025 23:38 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-5897 May 28, 2025 23:50 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5897 May 29, 2025 00:04 Inactive
@primer primer bot requested a review from a team as a code owner May 29, 2025 00:23
@primer primer bot requested a review from maximedegreve May 29, 2025 00:23
@mperrotti mperrotti added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit 6df6cbf May 29, 2025
35 checks passed
@mperrotti mperrotti deleted the mp/rm-dialog-btm-border branch May 29, 2025 12:13
@primer primer bot mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectahertz hectahertz hectahertz approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mperrotti @lesliecdubs @hectahertz
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy