chore: Cleanup the primer_react_css_modules_staff flag from the codebase #5968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e29eb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up removed feature flag code by eliminating all references to the primer_react_css_modules_staff flag across the codebase. Key changes include:
- Removing the staff flag check and declaration from NavList.tsx.
- Deleting the default setting for the staff flag in DefaultFeatureFlags.ts.
- Updating environment and workflow configurations to remove the staff flag variables.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/NavList/NavList.tsx | Removed the staff flag usage and updated conditional logic. |
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Removed the default entry for the staff flag. |
| packages/react/.storybook/preview.jsx | Updated the set of environment flags to exclude the staff flag. |
| .github/workflows/vrt-reports.yml | Removed the environment variable for the staff flag. |
| .github/workflows/aat-reports.yml | Removed the environment variable for the staff flag. |
size-limit report 📦
|
joshblack
approved these changes
Apr 24, 2025
hectahertz
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
primer_react_css_modules_staffflag has been removed from components, this PR cleans up the codebase of the flag.