Skip to content

Sync Project class with API spec #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 14, 2025
Merged

Sync Project class with API spec #3194

merged 6 commits into from
Feb 14, 2025

Conversation

EnricoMi
Copy link
Collaborator

Adds the following attributes:

  • organization_permission
  • private

Reworks tests for ProjectCard and ProjectColumn.

@EnricoMi
Updated class according to API spec
5b552d2
@EnricoMi
Move Project.testGetProject into testAttributes
b83d657
@EnricoMi
Updated test class according to API spec
f31bb0e
@EnricoMi
Updated test assertions
aa1aac8
@EnricoMi
Rework Project, ProjectColumn and ProjectCard tests
6bcd9b8 
- separate out ProjectColumn and ProjectCard test classes
- merged with existing ProjectColumn class
- add testAttributes tests
- remove redundant test data
@EnricoMi EnricoMi force-pushed the openapi/update-Project branch from 693a1ec to 6bcd9b8 Compare February 14, 2025 17:10
@github-actions GitHub Actions
Copy link

Test Results

    7 files  ±0      7 suites  ±0   4m 16s ⏱️ +4s
  992 tests  - 1    992 ✅  - 1  0 💤 ±0  0 ❌ ±0 
6 944 runs   - 7  6 943 ✅  - 7  1 💤 ±0  0 ❌ ±0 

Results for commit 5be8557. ± Comparison against base commit 882fe44.

This pull request removes 14 and adds 13 tests. Note that renamed tests count towards both. 
tests.Project.Project ‑ testCreateCardFromIssue
tests.Project.Project ‑ testCreateCardWithNote
tests.Project.Project ‑ testCreateColumn
tests.Project.Project ‑ testEditCardArchived
tests.Project.Project ‑ testEditCardNote
tests.Project.Project ‑ testEditCardWithoutParameters
tests.Project.Project ‑ testGetAllProjectCards
tests.Project.Project ‑ testGetProject
tests.Project.Project ‑ testGetProjectCardContent
tests.Project.Project ‑ testProjectAttributes
…

tests.Project.Project ‑ testAttributes
tests.ProjectCard.ProjectCard ‑ testAttributes
tests.ProjectCard.ProjectCard ‑ testCreateFromIssue
tests.ProjectCard.ProjectCard ‑ testCreateWithNote
tests.ProjectCard.ProjectCard ‑ testDelete
tests.ProjectCard.ProjectCard ‑ testEditArchived
tests.ProjectCard.ProjectCard ‑ testEditNote
tests.ProjectCard.ProjectCard ‑ testEditWithoutParameters
tests.ProjectCard.ProjectCard ‑ testGetAll
tests.ProjectCard.ProjectCard ‑ testGetContent
…

@EnricoMi EnricoMi merged commit 6ed8396 into PyGithub:main Feb 14, 2025
16 checks passed
@EnricoMi EnricoMi deleted the openapi/update-Project branch February 14, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EnricoMi
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy