docs: update docstring on Python for Bound API
#4274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
alex
approved these changes
Jun 21, 2024
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Jun 25, 2024
When available, using an already bound python token is zero-cost. Python::with_gil carries a runtime check. Ref: PyO3/pyo3#4274
andygrove
pushed a commit
to apache/datafusion-python
that referenced
this pull request
Jun 26, 2024
* let pyo3 convert the StorageContexts argument in PySessionContext::register_object_store * clean PySessionContext methods from_pylist and from_pydict * clean PySessionContext metehods from_polars, from_pandas, from_arrow_table * prefer bound Python token over Python::with_gil When available, using an already bound python token is zero-cost. Python::with_gil carries a runtime check. Ref: PyO3/pyo3#4274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docs on the
Pythontype to remove mentions to&PyAny, and remove some dead links.I also adjusted the "order of preference" to suggest
.py()where possible instead ofpy: Python<'py>in function arguments.