Skip to content

Invalid cookie keys will now raise an error. #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jun 7, 2024

Follow up to #2191 for Rack 3.2+.

@ioquatix ioquatix self-assigned this Jun 7, 2024
@ioquatix ioquatix added this to the v3.2.0 milestone Jun 7, 2024
@ioquatix ioquatix requested a review from jeremyevans June 11, 2024 06:03
@ioquatix ioquatix force-pushed the cookie-key-invalid-error branch from 02f4839 to b4ff29f Compare June 11, 2024 06:05
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unrelated changes to the CHANGELOG and version file makes it look like something went wrong in a rebase.

@ioquatix
Copy link
Member Author

Yeah not sure what happened here, the PR is completely bananas. I'll fix it.

@ioquatix ioquatix force-pushed the cookie-key-invalid-error branch from b4ff29f to b3154af Compare June 11, 2024 15:05
@ioquatix ioquatix requested a review from jeremyevans June 11, 2024 15:07
@ioquatix ioquatix merged commit f191c23 into rack:main Jun 11, 2024
@ioquatix ioquatix deleted the cookie-key-invalid-error branch June 11, 2024 15:44
@dentarg
Copy link
Contributor

dentarg commented Jun 11, 2024

@tenderlove Looks like you released this change with rack 3.1.1 (https://my.diffend.io/gems/rack/3.1.0/3.1.1)

@tenderlove
Copy link
Member

argh, sorry about that. I shipped the wrong branch. I'll fix it.

@tenderlove
Copy link
Member

@dentarg v3.1.2 should be shipped now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy