[Php70] Handle empty branch crash on unprintable char \x0C on EregToPregMatchRector #6368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed 🎉 /cc @bisenegger |
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
commented
Oct 9, 2024
| { | ||
| if ($normalizeUnprintableChar) { | ||
| $content = str_replace("\x0C", '\\\f', $content); |
There was a problem hiding this comment.
On scoper downgrade, it seems replaced with
if ($normalizeUnprintableChar) {
$content = \str_replace("\f", '\\\\f', $content);
}I will check when it deployed to getrector.com
There was a problem hiding this comment.
It seems working ok https://getrector.com/demo/b1ed83c8-c2a0-40bb-b3d4-0e098573f462
@bisenegger please try latest "rector/rector": "dev-main" and test if the issue persist, better if you can provide reproducible code like the link above, and better, provide patch as well if possible, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8854