Skip to content

fix(rolldown_plugin_json): incorrect default JSON export #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shulaoda
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a5baa47
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684a7586a0ccd50008cf6455

@shulaoda shulaoda requested a review from IWANABETHATGUY June 12, 2025 06:37
@shulaoda shulaoda marked this pull request as ready for review June 12, 2025 06:37
@shulaoda shulaoda added this pull request to the merge queue Jun 12, 2025
Copy link
Contributor

Benchmarks Rust

  • target: main(af2f2b4)
  • pr: 06-12-fix_rolldown_plugin_json_incorrect_default_json_export(a5baa47)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     80.3±2.98ms        ? ?/sec    1.00     78.5±3.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05     93.8±2.95ms        ? ?/sec    1.00     89.3±1.90ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    117.6±2.28ms        ? ?/sec    1.00    116.4±2.51ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    130.9±2.03ms        ? ?/sec    1.01    132.7±2.72ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.3±0.78ms        ? ?/sec    1.01     41.9±1.00ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     48.9±1.87ms        ? ?/sec    1.00     48.0±0.82ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    445.1±4.60ms        ? ?/sec    1.00    440.9±5.34ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    521.3±6.43ms        ? ?/sec    1.00    510.9±4.72ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.8±2.29ms        ? ?/sec    1.02     92.2±2.40ms        ? ?/sec
scan/scan@threejs                                            1.04     32.8±2.04ms        ? ?/sec    1.00     31.5±0.57ms        ? ?/sec
scan/scan@threejs10x                                         1.00    326.9±5.70ms        ? ?/sec    1.00    327.7±6.67ms        ? ?/sec

Merged via the queue into main with commit a94c792 Jun 12, 2025
24 checks passed
@shulaoda shulaoda deleted the 06-12-fix_rolldown_plugin_json_incorrect_default_json_export branch June 12, 2025 06:58
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy