Skip to content

fix: deduplicate entry point #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

fix: deduplicate entry point #4956

merged 1 commit into from
Jun 14, 2025

Conversation

IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 14, 2025 •
edited
Loading

Closed #4946

@IWANABETHATGUY Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify Netlify
Copy link

netlify bot commented Jun 14, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit d8b9baf
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/684d18928c10b800086f708c
😎 Deploy Preview https://deploy-preview-4956--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 4946 fix: deduplicate entry point Jun 14, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 14, 2025 06:25
graphite-app[bot]
graphite-app bot reviewed Jun 14, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-14-fix_4946 branch 3 times, most recently from 70c9b06 to 2401f25 Compare June 14, 2025 06:33
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     74.3±1.88ms        ? ?/sec    1.00     74.4±1.77ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     85.0±1.89ms        ? ?/sec    1.00     84.9±1.62ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.6±2.51ms        ? ?/sec    1.01    114.0±1.75ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.0±1.61ms        ? ?/sec    1.02    129.6±2.45ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.2±0.56ms        ? ?/sec    1.01     40.5±0.67ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.1±1.55ms        ? ?/sec    1.01     47.4±0.74ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    431.8±4.50ms        ? ?/sec    1.01    436.5±4.92ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    504.0±2.89ms        ? ?/sec    1.01    508.4±6.87ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.3±1.59ms        ? ?/sec    1.00     88.1±1.41ms        ? ?/sec
scan/scan@threejs                                            1.00     31.2±1.74ms        ? ?/sec    1.00     31.1±1.75ms        ? ?/sec
scan/scan@threejs10x                                         1.00    322.8±4.28ms        ? ?/sec    1.00    322.4±5.11ms        ? ?/sec

Merged via the queue into main with commit d00aae2 Jun 14, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-14-fix_4946 branch June 14, 2025 06:57
github-actions bot pushed a commit that referenced this pull request Jun 15, 2025
@shulaoda @github-actions
release: v1.0.0-beta.16
5a8075e 
## [1.0.0-beta.16] - 2025-06-15

### 🚀 Features

- rolldown: feat(rolldown): oxc v0.73.0 by @Boshen in [#4948](#4948)
- types: feat(types): generate HMR runtime types by @sapphi-red in [#4928](#4928)
- rolldown_plugin_build_import_analysis: feat(rolldown_plugin_build_import_analysis): align with rolldown-vite by @shulaoda in [#4931](#4931)
- feat: allow to configure`experimental#attachDebugInfo: 'none'` to disable generating `#region` comments by @TheAlexLichter in [#4918](#4918)

### 🐛 Bug Fixes

- fix: deduplicate entry point by @IWANABETHATGUY in [#4956](#4956)
- fix: diagnostic message on minified code is too long to be readable by @IWANABETHATGUY in [#4950](#4950)
- fix: deduplicated entry points when have same `id`, `name`, and `filename` by @IWANABETHATGUY in [#4947](#4947)
- fix: unbundle does not work with outExtensions by @IWANABETHATGUY in [#4945](#4945)
- types: fix(types): remove `undefined` from return type of `generateHmrPatch` and `hmrInvalidate` by @sapphi-red in [#4943](#4943)
- fix: handle error in `hmrInvalidate` by @sapphi-red in [#4942](#4942)
- rolldown_plugin_build_import_analysis: fix(rolldown_plugin_build_import_analysis): preload helper is imported even if it’s not needed by @shulaoda in [#4936](#4936)
- hmr: fix(hmr): avoid panic after syntax error by @sapphi-red in [#4898](#4898)
- strictExecutionOrder: fix(strictExecutionOrder): ensure initialization chain of entry exports by @hyf0 in [#4933](#4933)
- fix: should not panic when meet a syntax error in watch mode. by @IWANABETHATGUY in [#4926](#4926)
- fix: regression, id filter normalization for windows is not working by @IWANABETHATGUY in [#4922](#4922)
- rolldown_plugin_json: fix(rolldown_plugin_json): incorrect default JSON export by @shulaoda in [#4924](#4924)

### 🚜 Refactor

- refactor: avoid unnecessary collect by @IWANABETHATGUY in [#4949](#4949)
- refactor: get normalized options via binding by @IWANABETHATGUY in [#4938](#4938)
- refactor: include DevRuntime base class even if custom HMR implementation is passed by @sapphi-red in [#4929](#4929)

### 📚 Documentation

- docs: clarify minifier state by @TheAlexLichter in [#4953](#4953)
- docs: drafting code splitting by @hyf0 in [#4951](#4951)
- docs: add link to repl by @sxzz in [#4917](#4917)
- pluginutils: docs(pluginutils): add example to simple filter functions by @sapphi-red in [#4915](#4915)

### 🧪 Testing

- test: add testcase for normalized output options by @IWANABETHATGUY in [#4939](#4939)
- hmr: test(hmr): enable `expectExecuted` for `generatePatchError` test by @sapphi-red in [#4937](#4937)
- test: evaluate hmr tests in node by @sapphi-red in [#4930](#4930)
- test: add "non used export" hmr test by @sapphi-red in [#4900](#4900)
- test: enable expectExecuted in HMR tests by @sapphi-red in [#4927](#4927)

### ⚙️ Miscellaneous Tasks

- deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4866](#4866)
- infra: chore(infra): remove comments related to `cspell` by @shulaoda in [#4940](#4940)
- ci: remove cargo bench test by @IWANABETHATGUY in [#4925](#4925)
@Boshen Boshen mentioned this pull request Jun 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: generate n + 1 chunks, if user declare same entry n times
2 participants
@IWANABETHATGUY @hyf0
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy