refactor(binding): rename Bundler to BindingBundleImpl
#4983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d83f416 to
daa9358
Compare
hyf0
commented
Jun 17, 2025
hyf0
commented
Jun 17, 2025
Benchmarks Rust |
daa9358 to
d50c721
Compare
IWANABETHATGUY
approved these changes
Jun 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
> pnpm install 0.93s user 0.21s system 137% cpu 0.833 total - warm-up `pnpm install ` is fast enough. - `just` is smart enough to only execute `pnpm-install` once in any command. - reason: #4983 (comment)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
## [1.0.0-beta.17] - 2025-06-17 ### 🚀 Features - binding: feat(binding): always use the same `BindingBundler` to create `BindingBundlerImpl` for the same `RolldownBuild` by @hyf0 in [#4985](#4985) - debug: feat(debug): cache large string by @hyf0 in [#4882](#4882) - feat: make require('./foo.json') work as expected even if the json is transformed to JS by a custom plugin by @IWANABETHATGUY in [#4984](#4984) - feat: add diagnostic for multiple entries with UMD/IIFE formats by @shulaoda in [#4954](#4954) ### 🐛 Bug Fixes - plugin/vite-resolve: fix(plugin/vite-resolve): importing an optional peer dep should throw an runtime error by @sapphi-red in [#4980](#4980) - fix: upgrade napi, fix wasm url by @sxzz in [#4958](#4958) - fix: should rewrite hmr related ast after test if `experimental.hmr` is enabled. by @IWANABETHATGUY in [#4972](#4972) ### 💼 Other - build: provide `"type": "module"` in `package.json` by @iiio2 in [#4974](#4974) ### 🚜 Refactor - binding: refactor(binding): rename `Bundler` to `BindingBundleImpl` by @hyf0 in [#4983](#4983) - rolldown: refactor(rolldown): migrate to ESM package by @sxzz in [#4959](#4959) ### 📚 Documentation - docs: explain how to transpile legacy decorators by @hyf0 in [#4989](#4989) - code-splitting: docs(code-splitting): make terms bold instead of wrapped with inline code block by @hyf0 in [#4975](#4975) - docs: improve advanced chunks by @hyf0 in [#4966](#4966) - docs: refine code splitting guide by @sapphi-red in [#4969](#4969) ### 🧪 Testing - test: place empty `package.json` to prevent all files to be treated as node mode by @sapphi-red in [#4979](#4979) ### ⚙️ Miscellaneous Tasks - infra: chore(infra): ensure `pnpm install` for common commands by @hyf0 in [#4987](#4987) - browser: chore(browser): add `@oxc-project/runtime` by @shulaoda in [#4988](#4988) - deps: chore(deps): update dependency tsdown to v0.12.8 by @renovate[bot] in [#4977](#4977) - deps: chore(deps): update npm packages (major) by @renovate[bot] in [#4963](#4963) - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4967](#4967) - deps: chore(deps): lock file maintenance rust crates by @renovate[bot] in [#4965](#4965) - deps: chore(deps): lock file maintenance npm packages by @renovate[bot] in [#4964](#4964) - deps: chore(deps): update github-actions by @renovate[bot] in [#4962](#4962) ### ❤️ New Contributors * @iiio2 made their first contribution in [#4974](#4974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #4134.
Currently
RolldownBuildin nodejs might creates mutiple binding bundlers. This abstraction isn't proper anymore. We need a ruststructthat has the same lifetime matchsRolldownBuildin nodejs, which should be the one that has the nameBindingBundler.