Skip to content

[Fix #12208] Fix an incorrect autocorrect for the --disable-uncorrectable option #12220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

koic
Copy link
Member

@koic koic commented Sep 26, 2023

Fixes #12208.

This PR fixes an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ncorrectable` option

Fixes rubocop#12208.

This PR fixes an incorrect autocorrect for the `--disable-uncorrectable` command line option
when registering an offense is outside a percent array.
@koic koic force-pushed the fix_an_incorrect_autocorrect_for_disable_uncorrectable_option branch from ac00757 to d0d612e Compare September 26, 2023 04:17
@koic koic merged commit 59fb188 into rubocop:master Sep 26, 2023
@koic koic deleted the fix_an_incorrect_autocorrect_for_disable_uncorrectable_option branch September 26, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percent array literal inside a block causes infinite loop with --disable-uncorrectable.
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy