Fix incorrect autocorrect behavior for Layout/BlockAlignment
#13164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to the documentation, the autocorrect for `either` was set to `block_of_line`: > `either` (which is the default) : the `end` is allowed to be in either > location. The autocorrect will default to `start_of_line`. So this PR corrects it to `start_of_line`.
koic
commented
Aug 28, 2024
| @@ -502,7 +537,7 @@ def get_gems_by_name | |||
| def get_gems_by_name | |||
| @gems ||= Hash[*get_latest_gems.map { |gem| | |||
| [gem.name, gem, gem.full_name, gem] | |||
| }.flatten] | |||
| }.flatten] | |||
There was a problem hiding this comment.
NOTE: It is corrected to follow the expected autocorrect behavior according to the documentation.
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the documentation, the autocorrect for
eitherwas set toblock_of_line:So this PR corrects it to
start_of_line.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.