-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix false negatives for Style/MapIntoArray
when using non-splatted arguments
#13255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
reviewed
Sep 22, 2024
4400b27
to
77be0d2
Compare
vlad-pisanov
commented
Sep 23, 2024
@@ -53,12 +53,17 @@ class MapIntoArray < Base | |||
|
|||
MSG = 'Use `%<new_method_name>s` instead of `each` to map elements into an array.' | |||
|
|||
# @!method suitable_element?(node) | |||
def_node_matcher :suitable_element?, <<-PATTERN | |||
!{splat forwarded-restarg forwarded-args (block-pass nil?)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map { |x| ... }
, map { |x| * }
, map { |x| & }
aren't valid Ruby syntax, so we don't want to correct this type of forwarding
koic
reviewed
Sep 27, 2024
koic
reviewed
Sep 27, 2024
koic
reviewed
Sep 27, 2024
@vlad-pisanov Ping :-) |
@vlad-pisanov Can you take a look at this? |
77be0d2
to
da6842b
Compare
da6842b
to
512b032
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix #13119 fixed the splat bug in
Style/MapIntoArray
, but it also limited the types of offenses the cop recognized. For example,and several others are no longer detected as of 1.66.1
This PR restores the original cop behavior while preserving the splat fix.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.