Skip to content

Fix false negatives for Style/MapIntoArray when using non-splatted arguments #13255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

vlad-pisanov
Copy link
Contributor

Bugfix #13119 fixed the splat bug in Style/MapIntoArray, but it also limited the types of offenses the cop recognized. For example,

dest = []
arr.each { |e| dest << [1, e] }
arr.each { |e| dest << true }
arr.each { |e| dest << (cond? ? 1 : e) }

and several others are no longer detected as of 1.66.1

This PR restores the original cop behavior while preserving the splat fix.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@@ -53,12 +53,17 @@ class MapIntoArray < Base

MSG = 'Use `%<new_method_name>s` instead of `each` to map elements into an array.'

# @!method suitable_element?(node)
def_node_matcher :suitable_element?, <<-PATTERN
!{splat forwarded-restarg forwarded-args (block-pass nil?)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map { |x| ... }, map { |x| * }, map { |x| & } aren't valid Ruby syntax, so we don't want to correct this type of forwarding

@bbatsov
Copy link
Collaborator

bbatsov commented Oct 15, 2024

@vlad-pisanov Ping :-)

@koic
Copy link
Member

koic commented Oct 18, 2024

@vlad-pisanov Can you take a look at this?

@koic koic merged commit bbab877 into rubocop:master Oct 19, 2024
22 checks passed
@koic
Copy link
Member

koic commented Oct 19, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy