Skip to content

Fix false positive for Lint/FloatComparison against nil #13432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix false positive for Lint/FloatComparison against nil #13432

merged 1 commit into from
Nov 7, 2024

Conversation

lovro-bikic
Copy link
Contributor

@lovro-bikic lovro-bikic commented Nov 7, 2024

Hi! This PR fixes a false positive for Lint/FloatComparison against nil.

Here is an example when a false positive can occur:

Float(user_submitted_value, exception: false) == nil

If user_submitted_value is a value that cannot be made a Float, nil is returned because of the exception: false param.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@lovro-bikic lovro-bikic changed the title Fix false positive for Lint/FloatComparison against nil Fix false positive for Lint/FloatComparison against nil Nov 7, 2024
@dvandersluis
Copy link
Member

Can you add a note and example to the class comments to specify that nil is allowed?

@lovro-bikic
Copy link
Contributor Author

Done, let me know if it should be more detailed.

@dvandersluis dvandersluis merged commit 60365bf into rubocop:master Nov 7, 2024
22 checks passed
@dvandersluis
Copy link
Member

Thank you!

@lovro-bikic lovro-bikic deleted the feature/float-comparison-false-positive-against-nil branch November 7, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy