Fix Lint/LiteralInInterpolation cop error on invalid string literal
#13603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Dec 19, 2024
913d505 to
6ea3ddc
Compare
koic
reviewed
Dec 19, 2024
6ea3ddc to
245db4d
Compare
koic
reviewed
Dec 20, 2024
changelog/fix_lint_literal_in_interpolation_error_on_invalid_string.md
Outdated
Show resolved
Hide resolved
```console
echo '"#{"\201\203"}"' | rubocop --stdin bug.rb --only Lint/LiteralInInterpolation -d
An error occurred while Lint/LiteralInInterpolation cop was inspecting bug.rb:1:0.
invalid byte sequence in UTF-8
lib/active_support/core_ext/object/blank.rb:159:in `match?'
lib/active_support/core_ext/object/blank.rb:159:in `blank?'
lib/rubocop/cop/lint/literal_in_interpolation.rb:171:in `space_literal?'
lib/rubocop/cop/lint/literal_in_interpolation.rb:51:in `offending?'
lib/rubocop/cop/lint/literal_in_interpolation.rb:26:in `on_interpolation'
```
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
245db4d to
0d12b17
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Koichi ITO koic.ito@gmail.com
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.