Fix Style/ClassAndModuleChildren cop error on compact enforced style and unindented body
#13634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 5, 2025
| def unindent(corrector, node) | ||
| return if node.body.children.last.nil? | ||
|
|
||
| column_delta = configured_indentation_width - leading_spaces(node.body.children.last).size | ||
| last_children_leading_spaces = leading_spaces(node.body.children.last) |
There was a problem hiding this comment.
Since it is a single node, wouldn't last_child be more appropriate than last_children?
Suggested change
| last_children_leading_spaces = leading_spaces(node.body.children.last) | |
| last_child_leading_spaces = leading_spaces(node.body.children.last) |
koic
reviewed
Jan 5, 2025
| @@ -125,14 +125,19 @@ def remove_end(corrector, body) | |||
| corrector.remove(range) | |||
| end | |||
|
|
|||
| # rubocop:disable Metrics/AbcSize | |||
| def unindent(corrector, node) | |||
| return if node.body.children.last.nil? | |||
There was a problem hiding this comment.
To avoid Metrics/AbcSize, replacing it with unless could be considered.
Suggested change
| return if node.body.children.last.nil? | |
| return unless node.body.children.last |
…yle and unindented body If `Style/ClassAndModuleChildren` cop is configured with enforced style `compact`, the following code leads to and error (tree clobbering): ```ruby module M class C def main; TOPLEVEL_BINDING; end end end ``` I patched the cop to skip indentation autocorrection in such cases; they should be handled by `Layout/IndentationWidth`.
8adae2d to
8b7f077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Style/ClassAndModuleChildrencop is configured with enforced stylecompact, the following code leads to and error (tree clobbering):I patched the cop to skip indentation autocorrection in such cases; they should be handled by
Layout/IndentationWidth.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.