Fix Style/FloatDivision cop error on implicit receiver
#13642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bab3e46 to
cf26ed5
Compare
koic
reviewed
Jan 2, 2025
| PATTERN | ||
| # @!method any_coerce?(node) | ||
| def_node_matcher :any_coerce?, <<~PATTERN | ||
| {(send _ :/ (send _ :to_f)) (send (send _ :to_f) :/ _)} | ||
| {(send _ :/ (send !nil? :to_f)) (send (send !nil? :to_f) :/ _)} |
There was a problem hiding this comment.
Can you organize the corrections to follow the don't-repeat-yourself as shown below?
diff --git a/lib/rubocop/cop/style/float_division.rb b/lib/rubocop/cop/style/float_division.rb
index 790f6e19a..8a4022a77 100644
--- a/lib/rubocop/cop/style/float_division.rb
+++ b/lib/rubocop/cop/style/float_division.rb
@@ -65,19 +65,32 @@ module RuboCop
# @!method right_coerce?(node)
def_node_matcher :right_coerce?, <<~PATTERN
- (send _ :/ (send !nil? :to_f))
+ (send _ :/ #to_f_method?)
PATTERN
+
# @!method left_coerce?(node)
def_node_matcher :left_coerce?, <<~PATTERN
- (send (send !nil? :to_f) :/ _)
+ (send #to_f_method? :/ _)
PATTERN
+
# @!method both_coerce?(node)
def_node_matcher :both_coerce?, <<~PATTERN
- (send (send !nil? :to_f) :/ (send !nil? :to_f))
+ (send #to_f_method? :/ #to_f_method?)
PATTERN
+
# @!method any_coerce?(node)
def_node_matcher :any_coerce?, <<~PATTERN
- {(send _ :/ (send !nil? :to_f)) (send (send !nil? :to_f) :/ _)}
+ {(send _ :/ #to_f_method?) (send #to_f_method? :/ _)}
+ PATTERN
+
+ # @!method any_coerce?(node)
+ def_node_matcher :any_coerce?, <<~PATTERN
+ {(send _ :/ #to_f_method?) (send #to_f_method? :/ _)}
+ PATTERN
+
+ # @!method to_f_method?(node)
+ def_node_matcher :to_f_method?, <<~PATTERN
+ (send !nil? :to_f)
PATTERN
def on_send(node)There was a problem hiding this comment.
It appears to be a refactoring unrelated to the bug fix itself, but that's just my two cents 🙂
Done.
Cop `Style/FloatDivision` fails on implicit `#to_f` receiver. With `single_coerce` style: ```console echo 'a.to_f / to_f' | rubocop --only Style/FloatDivision -c <(echo 'Style/FloatDivision:\n EnforcedStyle: single_coerce') --stdin bug.rb -d An error occurred while Style/FloatDivision cop was inspecting bug.rb:1:0. Expected a Parser::Source::Range, Comment or RuboCop::AST::Node, got NilClass lib/rubocop/cop/corrector.rb:111:in `to_range' lib/rubocop/cop/corrector.rb:120:in `check_range_validity' lib/parser/source/tree_rewriter.rb:398:in `combine' lib/parser/source/tree_rewriter.rb:194:in `replace' lib/parser/source/tree_rewriter.rb:218:in `remove' lib/rubocop/cop/style/float_division.rb:126:in `remove_to_f_method' lib/rubocop/cop/style/float_division.rb:90:in `block in on_send' ``` With `left_coerce` or `right_coerce` or `fdiv`: ```console echo 'a / to_f' | rubocop --only Style/FloatDivision -c <(echo 'Style/FloatDivision:\n EnforcedStyle: left_coerce') --stdin bug.rb -d An error occurred while Style/FloatDivision cop was inspecting bug.rb:1:0. Expected a Parser::Source::Range, Comment or RuboCop::AST::Node, got NilClass ``` I think the best way to handle this is not to detect such code. Co-Authored-By: Koichi ITO <koic.ito@gmail.com>
cf26ed5 to
22d25bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cop
Style/FloatDivisionfails on implicit#to_freceiver.With
single_coercestyle:With
left_coerceorright_coerceorfdiv:I think the best way to handle this is not to detect such code.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.