Update Metrics/CollectionLiteralLength to only register for [] when called on Set
#13696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 14, 2025
Comment on lines
55
to
56
| # @!method set?(node) | ||
| def_node_matcher :set?, <<~PATTERN |
There was a problem hiding this comment.
That's my two cents. Can you rename to the following?
Suggested change
| # @!method set?(node) | |
| def_node_matcher :set?, <<~PATTERN | |
| # @!method set_const?(node) | |
| def_node_matcher :set_const?, <<~PATTERN |
There was a problem hiding this comment.
Sure thing, updated.
koic
reviewed
Jan 14, 2025
| def on_array(node) | ||
| add_offense(node) if node.children.length >= collection_threshold | ||
| end | ||
| alias on_hash on_array | ||
|
|
||
| def on_index(node) | ||
| return unless set?(node.receiver) |
There was a problem hiding this comment.
Suggested change
| return unless set?(node.receiver) | |
| return unless set_const?(node.receiver) |
…en called on `Set`
8395419 to
58e2299
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #11584,
Metrics/CollectionLiteralLengthwas only intended to apply to collection literals ([],{}andSet[]), but the cop was too restrictive, sofoo[...]would register an offense with more thanLengthThresholdelements.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.