Fix a false positive for Lint/AssignmentInCondition when assigning in numblocks
#13775
Conversation
…in numblocks The first block check is redundant, since the method already checks for blocks.
|
The JRuby CI matrix has failed. Can you rebase with the latest master branch? |
|
Ah, it seems it was already up to date, so I will re-run the CI. |
|
In any case, the JRuby failure is unrelated to this change, so let’s investigate it separately. Thank you. |
|
The failure looks related to the Probably have to pin it yet again until that is available in CI? |
|
The issue might be different this time and has been reported in jruby/jruby#8606. To avoid being affected by patch versions, the JRuby version will be pinned to 9.4.10.0 for a while. I've opened #13776. |
|
Ah, right. You removed it for 9.4.10.0 but then it started to fail again in 9.4.11.0. I thought that wasn't available yet for CI but it seems to be since about an hour ago! |
The first block check is redundant, since the method already checks for blocks.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.