Use glob patterns compatible with Packwerk and engines #1476
Conversation
| @@ -0,0 +1 @@ | |||
| * [#234](https://github.com/rubocop/rubocop-rails/issues/234): Use packwerk-compatible globs. ([@tdeo][]) | |||
There was a problem hiding this comment.
Could you also add a note about Engine? e.g.,
| * [#234](https://github.com/rubocop/rubocop-rails/issues/234): Use packwerk-compatible globs. ([@tdeo][]) | |
| * [#234](https://github.com/rubocop/rubocop-rails/issues/234): Use globs that are compatible with Engine or Packwerk. ([@tdeo][]) |
There was a problem hiding this comment.
Also, could you start the filename with change_ instead of new_?
There was a problem hiding this comment.
I did fix those 2 things
There was a problem hiding this comment.
There is no new changelog file, so it may not have been added with git add.
There was a problem hiding this comment.
Sorry for missing that 🤦
04a7636 to
caae7b2
Compare
|
@koic I believe this should now be ready |
|
Thanks! |
|
Hello, I've noticed some additional rubocop rules applying to files because of this change. The glob pattern applies when a parent folder is named For example I get these errors in spec/rails_helper (the full path name would be By renaming that base folder (which is not part of the rails project), they are excluded again. However, for my current project I can't rename that folder. Is this pattern matching intentional? If so, is there a way to avoid this? |
|
Hi @s2-cdd I hadn't anticipated that rubocop would compare paths going above project root, I'll try to have a deeper look at why that happens |
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Update glob patterns used in this repo to be compatible with Engine or Packwerk usage. Fixes #234
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.