-
-
Notifications
You must be signed in to change notification settings - Fork 327
Add printing of the lockfile after installation #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
index.js
Outdated
@@ -99,6 +99,9 @@ export async function setupRuby(options = {}) { | |||
if (inputs['bundler-cache'] === 'true') { | |||
await common.time('bundle install', async () => | |||
bundler.bundleInstall(gemfile, lockFile, platform, engine, version, bundlerVersion, inputs['cache-version'])) | |||
|
|||
await common.measure(`Print ${lockFile}`, async () => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eregon Thoughts here?
As an example , the Test with rails8 gemfile runs prints
> Print /home/runner/work/setup-ruby/setup-ruby/gemfiles/rails8.gemfile.lock
which I think looks like of verbose, but maybe it's ok?
Alternatively I could probably strip off the workspace directory, or just literally "Print lock file"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that looks too long, let's do Print lockfile
(which is spelled like in https://bundler.io/man/bundle-lock.1.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Fryguy See e8621f0#commitcomment-162888500 |
Oh interesting - I never expected lockfile to be null because it is passed to bundler.bundleInstall immediate before it. I'll add a test case for that. |
Closes #783