Skip to content

Add printing of the lockfile after installation #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

Fryguy
Copy link
Contributor

@Fryguy Fryguy commented Jul 24, 2025

Closes #783

index.js Outdated
@@ -99,6 +99,9 @@ export async function setupRuby(options = {}) {
if (inputs['bundler-cache'] === 'true') {
await common.time('bundle install', async () =>
bundler.bundleInstall(gemfile, lockFile, platform, engine, version, bundlerVersion, inputs['cache-version']))

await common.measure(`Print ${lockFile}`, async () =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eregon Thoughts here?

As an example , the Test with rails8 gemfile runs prints

> Print /home/runner/work/setup-ruby/setup-ruby/gemfiles/rails8.gemfile.lock

which I think looks like of verbose, but maybe it's ok?

Alternatively I could probably strip off the workspace directory, or just literally "Print lock file"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that looks too long, let's do Print lockfile (which is spelled like in https://bundler.io/man/bundle-lock.1.html)

@Fryguy Fryguy marked this pull request as ready for review July 24, 2025 21:02
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit e8621f0 into ruby:master Jul 25, 2025
190 checks passed
@eregon
Copy link
Member

eregon commented Jul 25, 2025

@Fryguy See e8621f0#commitcomment-162888500
Could you make the PR again and address that, and also adding a test for that case of using bundler-cache: true but having no Gemfile?

@Fryguy
Copy link
Contributor Author

Fryguy commented Jul 25, 2025

Oh interesting - I never expected lockfile to be null because it is passed to bundler.bundleInstall immediate before it. I'll add a test case for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print the final content of the Gemfile.lock
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy