Fix stream-related tests with Node 22.5.0 #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,11 +149,12 @@ test('.duplex() can pipe to errored stream with Stream.pipeline()', async t => { | |||
| outputStream.destroy(cause); | |||
|
|
|||
| await assertPromiseError(t, pipeline(inputStream, stream, outputStream), cause); | |||
| await t.throwsAsync(finishedStream(stream)); | |||
There was a problem hiding this comment.
Hi @ehmicky hope you are doing well!
I just came from the linked PR and I am wondering if you could let me know why this fix the tests (I tried to access the failure log but seems they aren't available anymore) cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 22.5.0 introduced some changes to error handling with
stream.pipeline(): nodejs/node#53462Those changes are making some of our tests fail (https://github.com/sindresorhus/execa/actions/runs/9628628974). This PR is fixing those.