feat: include an 'api' option to customize the slack api method url #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 7 7
Lines 699 702 +3
=======================================
+ Hits 698 701 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@WilliamBergamin Thank you for the review! 🙏 ✨ I've confirmed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an
apioption to the inputs of this action as a "custom API URL to send Slack API method requests to".Resolves #389.
Preview
- name: Send to a custom API URL uses: slackapi/slack-github-action@v2.0.0 with: + api: http://localhost:8080 method: chat.postMessage token: ${{ secrets.SLACK_BOT_TOKEN }} payload: | channel: ${{ secrets.SLACK_CHANNEL_ID }} text: "What's happening on localhost?"Notes
Changes in this PR also include refactors of #408 needed for testing 🙏 ✨
Super open to naming suggestions since "api" might not be so clear right away, but IMO it matches "method" well 🤔
Requirements