docs: pulls out variables into separate page #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 7 7
Lines 702 702
=======================================
Hits 701 701
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
approved these changes
Apr 3, 2025
Woah. I'm now realizing that this lets us merge docs PRs separate from the "released" docs 📚 ✨ IIRC we've had pain points around merging bug fixes in documentation separate from feature additions and our release cycles, but it now could we hold off on merging certain PRs until a stable release!? 🚀 |
|
☝️ With those "certain PRs" meaning the PRs created for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The homepage should be a home page not a home and topic page. now this topic is on a page.
We're immediately testing the worst edge case -- the resulting PR in the docusaurus repo will need to be modified to add the page to
sidebar.js. Not too cumbersome to do via web client thoughRequirements (place an
xin each[ ])